Closed
Bug 789787
Opened 12 years ago
Closed 11 years ago
Thunderbird build with Windows SDK 8.0 fails because MAPI headers are missing
Categories
(MailNews Core :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 25.0
People
(Reporter: rain1, Assigned: m_kato)
References
Details
Attachments
(2 files, 6 obsolete files)
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
A Thunderbird build using the Windows SDK 8.0 fails because the MAPI headers aren't found.
https://connect.microsoft.com/VisualStudio/feedback/details/728601/visual-c-mapiutil-h-and-xcmc-h-are-missing-from-platform-sdk-included-with-vc11-beta
Reporter | ||
Comment 1•12 years ago
|
||
Installing the MAPI headers separately seems to be the only option. I've hacked the install path into INCLUDE locally. http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=12905
I couldn't find the path anywhere in the registry, so the reg trick we use to locate the DirectX SDK won't work. This sucks. We'll probably have to hardcode the default path and provide a configure option to set it.
Assignee | ||
Comment 2•12 years ago
|
||
We should check mapix.h in configure.in
Component: Simple MAPI → Build Config
Assignee | ||
Comment 3•12 years ago
|
||
Assignee: nobody → m_kato
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 721060 [details] [diff] [review]
Part 1. Build config change (detect MAPI header and add --disable-mapi)
Windows 8 SDK has no MAPI headers. Even if no MAPI header, we should support it with --disable-mapi.
Also we can download MAPI header from microsoft.com.
Attachment #721060 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 721062 [details] [diff] [review]
Part 2. can build mailnews if no mapi header
If no MAPI header in build environment, we should support it even if MSVC.
Attachment #721062 -
Flags: review?(mbanner)
Comment 7•12 years ago
|
||
Comment on attachment 721060 [details] [diff] [review]
Part 1. Build config change (detect MAPI header and add --disable-mapi)
Hi Makato, could you refresh this now that bug 846540 has landed - you need to move the changes to mail/configure.in and suite/configure.in.
I'll be happy to review both patches - I can review them as one.
Attachment #721060 -
Flags: review?(bugspam.Callek)
Updated•12 years ago
|
Attachment #721062 -
Flags: review?(mbanner)
Assignee | ||
Comment 8•12 years ago
|
||
Attachment #721060 -
Attachment is obsolete: true
Attachment #737783 -
Flags: review?(mbanner)
Assignee | ||
Comment 9•12 years ago
|
||
Attachment #721062 -
Attachment is obsolete: true
Attachment #737785 -
Flags: review?(mbanner)
Assignee | ||
Comment 10•12 years ago
|
||
Comment on attachment 737783 [details] [diff] [review]
Part 1. Build config change (detect MAPI header and add --disable-mapi)
I need update again.
Attachment #737783 -
Flags: review?(mbanner)
Assignee | ||
Comment 11•12 years ago
|
||
Attachment #737783 -
Attachment is obsolete: true
Attachment #738367 -
Flags: review?(mbanner)
Assignee | ||
Comment 12•12 years ago
|
||
Comment on attachment 737785 [details] [diff] [review]
Part 2. can build mailnews if no mapi header
Sorry, I forget update suite/*
Attachment #737785 -
Flags: review?(mbanner)
Assignee | ||
Comment 13•12 years ago
|
||
Comment on attachment 738367 [details] [diff] [review]
Part 1. build config change
sorry, I forget udapte suite/*
Attachment #738367 -
Flags: review?(mbanner)
Assignee | ||
Comment 14•12 years ago
|
||
add --disable-mapi flag
Attachment #738367 -
Attachment is obsolete: true
Attachment #738368 -
Flags: review?(mbanner)
Comment 15•12 years ago
|
||
Comment on attachment 738368 [details] [diff] [review]
Part 1. build config change
As this is just manually disabling, I think that's fine.
Attachment #738368 -
Flags: review?(mbanner) → review+
Comment 16•12 years ago
|
||
and here's the unbitrotted patch for you.
Attachment #738368 -
Attachment is obsolete: true
Attachment #746969 -
Flags: review+
Comment 17•12 years ago
|
||
I'm fine with this patch as well (attaching unbitrotted version).
Attachment #737785 -
Attachment is obsolete: true
Attachment #746971 -
Flags: review+
Comment 18•11 years ago
|
||
I've just landed this as it'll help people struggling with the mapi headers.
https://hg.mozilla.org/comm-central/rev/a5ad797c274a
https://hg.mozilla.org/comm-central/rev/bfe4e360ee05
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
Comment 19•11 years ago
|
||
Doesn't Suite need this bit as well?
https://hg.mozilla.org/comm-central/rev/bfe4e360ee05#l1.12
Assignee | ||
Comment 20•11 years ago
|
||
(In reply to Philip Chee from comment #19)
> Doesn't Suite need this bit as well?
> https://hg.mozilla.org/comm-central/rev/bfe4e360ee05#l1.12
https://hg.mozilla.org/comm-central/rev/a5ad797c274a has buildconfig change for suite too.
Comment 21•9 years ago
|
||
Where do the headers need to go? I'm assuming they aren't being looked for in
C:\Office 2010 Developer Resources\Outlook 2010 MAPI Headers
Comment 22•9 years ago
|
||
Never mind. If anyone else ends up here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites
You need to log in
before you can comment on or make changes to this bug.
Description
•