Closed
Bug 789830
Opened 12 years ago
Closed 12 years ago
Graphics driver DriverVersion and DriverDate no longer present in registry location in Windows 8 (about:support and graphics driver blacklisting breaks -- possibly AMD only?)
Categories
(Core :: Graphics, defect)
Tracking
()
VERIFIED
FIXED
mozilla18
People
(Reporter: rain1, Assigned: rain1)
References
Details
(Whiteboard: [Win8])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
rain1
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
GfxInfo queries HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Class\{4d36e968-e325-11ce-bfc1-08002be10318}\0000 for DriverVersion and DriverDate -- apparently with Windows 8 (at least on my AMD machine) the registry entries are no longer present.
Assignee | ||
Updated•12 years ago
|
Summary: Graphics driver DriverVersion and DriverDate no longer present in registry location in Windows 8 → Graphics driver DriverVersion and DriverDate no longer present in registry location in Windows 8 (about:support breaks)
Assignee | ||
Comment 1•12 years ago
|
||
This is pretty major because about:support breaks.
Severity: normal → major
Assignee | ||
Comment 2•12 years ago
|
||
I searched through the entire registry for 8.982.0.0000 (my driver version) and couldn't find it except in a couple of AMD-specific locations.
Assignee | ||
Comment 3•12 years ago
|
||
Maybe we should use http://msdn.microsoft.com/en-us/library/windows/hardware/ff551018 -- that seems to contain a driver date and version.
Comment 4•12 years ago
|
||
We should perhaps see where SetupDiEnumDriverInfo gets it's information from. In previous versions of Windows it used the same registry keys that we're currently using.
Assignee | ||
Comment 5•12 years ago
|
||
I tried looking but didn't find anything.
Why not just use SetupDiEnumDriverInfo?
Assignee | ||
Comment 6•12 years ago
|
||
Note that this is fine in my VMware VM -- the DriverDate and DriverVersion are present where expected. It's only on my physical install that they're missing.
Comment 7•12 years ago
|
||
Nominating this for tracking-firefox16 and 17. It would be good to fix this in Firefox 16 so that we have a working about:support before Windows 8 ships to retail.
tracking-firefox16:
--- → ?
tracking-firefox17:
--- → ?
Updated•12 years ago
|
Comment 8•12 years ago
|
||
Assigning to Joe to either take this on or find the right person who will since we're a day away from Beta 3 so tracking this for 16 means we'll want a fix ready for uplift in the next 2.5 weeks
Assignee: nobody → joe
Updated•12 years ago
|
Whiteboard: [Win8]
Assignee | ||
Updated•12 years ago
|
Summary: Graphics driver DriverVersion and DriverDate no longer present in registry location in Windows 8 (about:support breaks) → Graphics driver DriverVersion and DriverDate no longer present in registry location in Windows 8 (about:support and graphics driver blacklisting breaks -- possibly AMD only?)
Assignee | ||
Comment 9•12 years ago
|
||
What I'd suggest is that if the driver details aren't present in the registry we should always assume the worst (an epoch date and a 0.0.0.0 version).
Assignee | ||
Comment 10•12 years ago
|
||
This works, but it might confuse anyone looking at about:support.
Attachment #661630 -
Flags: review?(joe)
Comment 11•12 years ago
|
||
Comment on attachment 661630 [details] [diff] [review]
proposed patch
Review of attachment 661630 [details] [diff] [review]:
-----------------------------------------------------------------
::: widget/windows/GfxInfo.cpp
@@ +327,4 @@
> mDriverDate = value;
> + } else {
> + // Again, assume the worst
> + mDriverDate = L"01-01-1970";
If you want, append (driver info not found) to this string (it's never parsed by Firefox code, anyways).
Attachment #661630 -
Flags: review?(joe) → review+
Comment 12•12 years ago
|
||
To be clear, this is a workaround only: whatever systems are affected by this will be blacklisted from all hardware acceleration. So I suggest we either [leave open] this bug for a permanent fix, or file a follow-up bug for same.
Assignee | ||
Comment 13•12 years ago
|
||
Per an IRC discussion with Joe, I didn't make the (driver info not found) change because of l10n issues. I also switched to AssignLiteral to avoid potential issues with mingw.
http://hg.mozilla.org/integration/mozilla-inbound/rev/b9622f2801fc
Assignee: joe → sagarwal
Attachment #661630 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #661844 -
Flags: review+
Attachment #661844 -
Flags: approval-mozilla-beta?
Attachment #661844 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•12 years ago
|
Attachment #661844 -
Flags: approval-mozilla-beta?
Attachment #661844 -
Flags: approval-mozilla-aurora?
Comment 14•12 years ago
|
||
Comment on attachment 661844 [details] [diff] [review]
what I checked in
[Approval Request Comment]
Bug caused by (feature/regressing bug #): not a regression
User impact if declined: hardware acceleration enabled even on machines where it shouldn't be.
Testing completed (on m-c, etc.): limited
Risk to taking this patch (and alternatives if risky): not risky. However, this could make people we would otherwise allow to have hardware acceleration appear to be "blacklisted" on Windows 8; this is not actually a fix to this bug, but is instead a more correct handling of error cases.
String or UUID changes made by this patch: none
Attachment #661844 -
Flags: approval-mozilla-beta?
Attachment #661844 -
Flags: approval-mozilla-aurora?
Comment 15•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment 16•12 years ago
|
||
Comment on attachment 661844 [details] [diff] [review]
what I checked in
[Triage Comment]
Let's take this in support of bug 783517, given the low risk profile.
Attachment #661844 -
Flags: approval-mozilla-beta?
Attachment #661844 -
Flags: approval-mozilla-beta+
Attachment #661844 -
Flags: approval-mozilla-aurora?
Attachment #661844 -
Flags: approval-mozilla-aurora+
Comment 17•12 years ago
|
||
(and please land asap today)
Comment 18•12 years ago
|
||
Comment 19•12 years ago
|
||
I tried to reproduce the initial issue, but I couldn't. The driver version and date are present in the about:support and also in the registry under:
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Class\{4d36e968-e325-11ce-bfc1-08002be10318}\0000
I also see many registry entries (about 20) like HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Class\{4d36e968-e325-11ce-bfc1-08002be10318}\0000. Only one of them has the correct driver version and date. The rest of them have the driver date and version outdated (6-21-2006 and 6.2.9200.16384).
I have the same Driver version as the one mentioned in Comment 2 (8.982.0.0).
Is there anything I can do to properly set up the environment to verify this?
Assignee | ||
Comment 20•12 years ago
|
||
You can delete DriverDate and DriverVersion at HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Class\{4d36e968-e325-11ce-bfc1-08002be10318}\0000, then start up Firefox. (Remember to put them back later.)
Comment 21•12 years ago
|
||
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:16.0) Gecko/20100101 Firefox/16.0 rc build
Verified the fix using the suggestions from comment #20 and it works as expected: Graphics details are listed in about:support with DriverDate 1-01-1970 and Driver Version 0.0.0.0 if their entries are removed from registry.
Still, graphics section of about:support remains broken if only the values of DriverDate and DriverVersion are removed (blank value). However, this is an edge case and I think this bug can be marked verified for now. Please let me know if you want to address this in a followup bug.
QA Contact: mihaela.velimiroviciu
Comment 22•12 years ago
|
||
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 beta 1
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0
Verified the fix on the above builds and it looks ok with the note from comment #21
You need to log in
before you can comment on or make changes to this bug.
Description
•