Closed
Bug 790136
Opened 12 years ago
Closed 12 years ago
[b2g-bluetooth] Register HFP_AG/HSP_AG services
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: echou, Assigned: echou)
References
Details
(Whiteboard: [LOE:S])
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
In order to tell other Bluetooth devices that we support HFP/HSP, we need to register HFP_AG/HSP_AG in SDP database.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #660296 -
Flags: review?(kyle)
Assignee | ||
Comment 2•12 years ago
|
||
BluetoothDBusService::StopInternal() should be called before really turning down Bluetooth, otherwise actions like RemoveReservedServices wouldn't be able to executed because bluetoothd was already killed after StartStopBluetooth(false).
Attachment #660298 -
Flags: review?(kyle)
Assignee | ||
Comment 3•12 years ago
|
||
Services are registered after adapter path is created. Services are unregistered before shutdown Bluetooth. I kept the adapterPath as a static nsString for unregistering use and updated it whenever we got adapteradded event.
Attachment #660303 -
Flags: review?(kyle)
Assignee | ||
Updated•12 years ago
|
Attachment #660303 -
Attachment description: patch 3: v3: Registered/Unregistered HFP_AG/HSP_AG services → patch 3: v1: Registered/Unregistered HFP_AG/HSP_AG services
Updated•12 years ago
|
Attachment #660296 -
Flags: review?(kyle) → review+
Updated•12 years ago
|
Attachment #660298 -
Flags: review?(kyle) → review+
Comment 4•12 years ago
|
||
Comment on attachment 660303 [details] [diff] [review]
patch 3: v1: Registered/Unregistered HFP_AG/HSP_AG services
Review of attachment 660303 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +568,5 @@
> +
> + uuids.AppendElement((uint32_t)(BluetoothServiceUuid::HandsfreeAG >> 32));
> + uuids.AppendElement((uint32_t)(BluetoothServiceUuid::HeadsetAG >> 32));
> +
> + BluetoothService* bs = BluetoothService::Get();
Nit: Might want to try to get service before building the uuids, just to save some work.
Attachment #660303 -
Flags: review?(kyle) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Assignee | ||
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/191e77d35ca5
https://hg.mozilla.org/mozilla-central/rev/0d50672b64b4
https://hg.mozilla.org/mozilla-central/rev/e3c8270cfefe
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•