Closed
Bug 790395
Opened 12 years ago
Closed 12 years ago
error: api-utils: TEST FAILED: test-content-proxy.testCrossDomainIframe (failure)
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.11
People
(Reporter: KWierso, Assigned: ochameau)
References
Details
Attachments
(1 file)
I'm seeing this test failure now with every run on inbound when https://hg.mozilla.org/integration/mozilla-inbound/rev/634a2b9859ab landed. error: api-utils: TEST FAILED: test-content-proxy.testCrossDomainIframe (failure) error: api-utils: fail: COW fails : Permission denied to access property 'toString' ++DOMWINDOW == 37 (0x12eb3d970) [serial = 37] [outer = 0x12c0dddc0] WARNING: Unable to test style tree integrity -- no content node: file ../../../layout/base/nsCSSFrameConstructor.cpp, line 8209 info: api-utils: Traceback (most recent call last): File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/timer.js", line 28, in notify callback.apply(null, args); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/content/worker.js", line 100, in null self._emit.apply(self, JSON.parse(args)); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/events.js", line 119, in _emit return this._emitOnObject.apply(this, args); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/events.js", line 149, in _emitOnObject listener.apply(targetObj, params); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/content/worker.js", line 215, in portEmit self._addonWorker._onContentScriptEvent.apply(self._addonWorker, arguments); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/content/worker.js", line 513, in _onContentScriptEvent this._port._emit.apply(this._port, arguments); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/events.js", line 119, in _emit return this._emitOnObject.apply(this, args); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/events.js", line 149, in _emitOnObject listener.apply(targetObj, params); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/tests/test-content-proxy.js", line 84, in null test.assert(data.assertion, data.msg); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/unit-test.js", line 133, in assert this.fail(message); File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/unit-test.js", line 71, in fail this.console.trace();
Updated•12 years ago
|
Assignee: nobody → ejpbruel
Updated•12 years ago
|
Depends on: CVE-2012-4193
Updated•12 years ago
|
Keywords: sec-critical
Updated•12 years ago
|
Keywords: sec-critical
Assignee | ||
Comment 1•12 years ago
|
||
The cross domain test was quite limited and didn't reflected any real usecase. But there is some real usecase where a content script want to do something with an iframe on another domain, like passing messages. And we need to ensure that it works correctly in content scripts. I've improved this test to test this and avoid any unsafe or non-standard practices like String(...).
Assignee: ejpbruel → poirot.alex
Attachment #660410 -
Flags: review?(evold)
Reporter | ||
Updated•12 years ago
|
Priority: -- → P1
Updated•12 years ago
|
Attachment #660410 -
Flags: review?(evold) → review+
Comment 2•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/77b1987c9608acc628f9e641c3c796167d5fcc93 Bug 790395: Improve cross domain content script unit test with a real usecase. https://github.com/mozilla/addon-sdk/commit/321667ea33ea20fef9f4c7a0c2d03dd5ea29d5d8 Merge pull request #567 from ochameau/bug/790395 Bug 790395: Improve cross domain content script unit test with a real usecase. r=@erikvold
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → 1.11
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•12 years ago
|
||
Reopening so we can track the push I just made to inbound in https://hg.mozilla.org/integration/mozilla-inbound/rev/def643b50ef1 to get the fix over to mozilla-central.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/def643b50ef1
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•