We should add support for 'SET UP EVENT LIST' proactive command to let web-apps to monitor those events needed by ICC.

Yoshi, is this a basecamp blocker?

Yes, it's needed in Brazil.

updated documentation in IDL.

Comment on attachment 661116 [details] [diff] [review] Part 1: Update IDL. v2 Hi, philikon This patch updates the IDL for supporting SET_UP_EVENT_LIST proactive command, would you help to review this ? Thanks

Comment on attachment 661115 [details] [diff] [review] Part 2: Update RIL Hi, philikon This part is about the implementation. Thanks

Comment on attachment 661115 [details] [diff] [review] Part 2: Update RIL Review of attachment 661115 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +5525,5 @@ > + throw new Error("Stk Display Text: Required value missing : Event List"); > + } > + > + return { > + eventList: ctlv.value ? ctlv.value.eventList : null Can't we reuse ctlv.value? Like so: if (ctlv.value) { return ctlv.value; } return { eventList: null }; r=me with that.

Comment on attachment 661116 [details] [diff] [review] Part 1: Update IDL. v2 Hi, sicking The purpose of this patch is, when ICC(or SIM) sends STK_CMD_SET_UP_EVENT_LIST to ME(or phone), it tells ME the list of events that shall be monitored by ME, so when one of these events is happened, ICC shall be notified. (Notifying those events are addressed in Bug 795047, Bug 791935) Would you review this for me ? Thank you.

Addressed to philikon's comments: reuse ctlv.value Thanks

Comment on attachment 661116 [details] [diff] [review] Part 1: Update IDL. v2 Review of attachment 661116 [details] [diff] [review]: ----------------------------------------------------------------- I've probably mentioned this before, but ideally these things should be strings rather than enums. But this is totally fine for now.

(In reply to Jonas Sicking (:sicking) from comment #11) > Comment on attachment 661116 [details] [diff] [review] > Part 1: Update IDL. v2 > > Review of attachment 661116 [details] [diff] [review]: > ----------------------------------------------------------------- > > I've probably mentioned this before, but ideally these things should be > strings rather than enums. But this is totally fine for now. Hi Jonas Yes, you have mentioned it before, but currently we're running out of time, so I would like to finish all required features first. Also to make it consistent, I still use 'unsigned short' in new patch instead of 'string'. I definitely will change it to string when these features is completed. :) Thank you.

Fixed typos.

try result https://tbpl.mozilla.org/?tree=Try&rev=645ade829385

https://hg.mozilla.org/integration/mozilla-inbound/rev/99ff1aef50a2 https://hg.mozilla.org/integration/mozilla-inbound/rev/7006a89424bf

https://hg.mozilla.org/mozilla-central/rev/99ff1aef50a2 https://hg.mozilla.org/mozilla-central/rev/7006a89424bf