Closed Bug 790768 Opened 12 years ago Closed 6 years ago

MOZ_DUMP_PAINT_TO_FILE does not work on B2G phone

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-basecamp:-)

RESOLVED WONTFIX
blocking-basecamp -

People

(Reporter: bjacob, Assigned: gal)

References

Details

Attachments

(1 file, 2 obsolete files)

Reason unclear. I tried prepending the filenames with "/data/local/tmp" so that they would go into that directory where we have write permissions, but no file gets created there.

Fixing this should be useful to help debugging rendering bugs such as bug 790764, bug 790723.
Here is what I tried, and didn't work:

bjacob:/hack/b2g/B2G/gecko$ git diff layout
diff --git a/layout/base/nsLayoutUtils.cpp b/layout/base/nsLayoutUtils.cpp
index 64f8666..a69d3e6 100644
--- a/layout/base/nsLayoutUtils.cpp
+++ b/layout/base/nsLayoutUtils.cpp
@@ -1814,7 +1814,11 @@ nsLayoutUtils::PaintFrame(nsRenderingContext* aRenderingContext, nsIF
 #ifdef MOZ_DUMP_PAINTING
   if (gfxUtils::sDumpPaintList || gfxUtils::sDumpPainting) {
     if (gfxUtils::sDumpPaintingToFile) {
-      nsCString string("dump-");
+      nsCString string;
+#ifdef MOZ_WIDGET_GONK
+      string.Append("/data/local/tmp");
+#endif
+      string.Append("dump-");
       string.AppendInt(gPaintCount);
       string.Append(".html");
       gfxUtils::sDumpPaintFile = fopen(string.BeginReading(), "w");
I ran into the same problem quite some time ago (bug 737319). I looked into a bit and I think it all gets screwed up due to OMTC. My recollection of the problem that the dump file gets opened/closed on one thread, but the writing of the data into the file descriptor happens on another thread, after the dump file has been closed.
(In reply to Benoit Jacob [:bjacob] from comment #1)
> +      string.Append("/data/local/tmp");

I was missing a trailing / here, but it still doesn't work with it.
blocking-basecamp: --- → ?
This is not a user visible feature.
blocking-basecamp: ? → -
Attached patch patch (obsolete) (deleted) — Splinter Review
Assignee: nobody → gal
Attached patch patch (obsolete) (deleted) — Splinter Review
Attachment #682861 - Attachment is obsolete: true
Attached patch patch (deleted) — Splinter Review
Attachment #682862 - Attachment is obsolete: true
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: