Closed Bug 79097 Opened 24 years ago Closed 23 years ago

imapFolderProps.xul is a misleading name

Categories

(SeaMonkey :: MailNews: Message Display, defect, P2)

x86
All
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.3

People

(Reporter: hwaara, Assigned: hwaara)

References

Details

(Whiteboard: fix in hand)

Attachments

(1 file)

imapFolderProps.xul is a misleading name for a file that is used for NNTP and POP3 too. I had a hard time finding the props dialog for POP3 when I realized that this is used for all. I suggest we rename it to folderProps.xul, as the JS file is named folderProps.js.
I'm not doing the UI. Reassign to Diane, cc Mohan.
Assignee: bienvenu → dianesun
reassign to Mohanb
to mohanb
Assignee: dianesun → mohanb
Target Milestone: --- → mozilla0.9.1
Priority: -- → P2
Setting target milestone to 0.9.2 (check it in anytime, even before, when the tree is open for). Per PDT triage.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Moving to TFV 0.9.3.
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Attached patch fix (deleted) — Splinter Review
This fix is simple: * It renames imapFolderProps.xul to folderProps.xul in those 4 places LXR showed me: http://lxr.mozilla.org/seamonkey/search?string=imapFolderProps * Plus that it renames the actual file. ;) Mohanb can you review?
Bhuvan or Naving, could you review my simple patch in this bug?
rs=sspitzer just make sure that when you check in that you use the most up-to-date version of imapFolderProps.xul for your folderProps.xul
r=naving
Taking since I have the fix in hand.
Assignee: mohanb → hwaara
Target Milestone: mozilla0.9.3 → mozilla0.9.2
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Blocks: 83989
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Moving back to 0.9.2 ... got approval from Asa to the 0.9.2 trunk via IRC
Target Milestone: mozilla0.9.3 → mozilla0.9.2
Status: NEW → ASSIGNED
Whiteboard: fix in hand
Target Milestone: mozilla0.9.2 → mozilla0.9.3
I don't feel that this is worth it (the risk is higher than the gain) for 0.9.2, so moving back to 0.9.3. Will checkin when trunk unfreezes some day...
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: esther → stephend
Verified FIXED using lxr.mozilla.org
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: