Closed Bug 791518 Opened 12 years ago Closed 12 years ago

crash [@ nsDragService::TargetDataReceived] dragging a tab to a different Firefox process

Categories

(Core :: Widget: Gtk, defect)

18 Branch
x86_64
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: MatsPalmgren_bugz, Unassigned)

References

Details

(Keywords: crash, regression, reproducible)

Crash Data

Attachments

(2 files)

Attached file stack + data (deleted) —
STR
1. start two Firefox processes (using different profiles)
2. open a few tabs in each
3. drag a tab and hover the tab bar of the other Firefox

ACTUAL RESULTS
crash at:
nsDragService::TargetDataReceived
nsWindow::OnDragDataReceivedEvent
drag_data_received_event_cb
...

see attached stack for further details.
Attached patch fix (deleted) — Splinter Review
This fixes the crash.
Attachment #661558 - Flags: review?(karlt)
Crash Signature: [@ nsDragService::TargetDataReceived]
Version: unspecified → Trunk
Last good nightly: 2012-09-14
First bad nightly: 2012-09-15

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e5af3d785252&tochange=9fff2012b66c
Blocks: gtk3
Keywords: regression
Version: Trunk → 18 Branch
Crash Signature: [@ nsDragService::TargetDataReceived] → [@ nsDragService::TargetDataReceived ]
Comment on attachment 661558 [details] [diff] [review]
fix

Thanks.  I would hope the check for non-null data would be unnecessary now that len is signed, but an extra check is harmless at worst.
Attachment #661558 - Flags: review?(karlt) → review+
https://hg.mozilla.org/mozilla-central/rev/5a416b380f4a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Blocks: 1034064
No longer blocks: 1034064
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: