Closed
Bug 791706
Opened 12 years ago
Closed 11 years ago
[MP] Story - Search defaults for v1
Categories
(Firefox for Metro Graveyard :: General, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 27
People
(Reporter: jimm, Assigned: bbondy)
References
Details
(Whiteboard: [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=1)
Attachments
(2 files, 2 obsolete files)
Just want to be sure these are set appropriately:
keyword search from the address bar:
google
search engine list on the awesome screen:
google
amazon
bing
ebay
twitter
wikipedia
yahoo
Comment 1•12 years ago
|
||
Assigning to Asa to verify whether our current settings (comment 0) are correct or to determine any changes we need to make.
Assignee: nobody → asa
Reporter | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
Please strip out the channel parameters from the Google Firefox search plugin and replace client=firefox with client=metrofirefox
Reporter | ||
Updated•12 years ago
|
Whiteboard: metro-preview → metro-beta, mc-merge
Reporter | ||
Updated•12 years ago
|
Product: Firefox → Firefox for Metro
Updated•12 years ago
|
Whiteboard: metro-beta, mc-merge → [metro-mvp], mc-merge
Reporter | ||
Updated•12 years ago
|
Whiteboard: [metro-mvp], mc-merge → [metro-mvp], mc-merge, LOE:-
Updated•12 years ago
|
Whiteboard: [metro-mvp], mc-merge, LOE:- → [metro-mvp] [LOE:-] mc-merge
Updated•12 years ago
|
Blocks: 831903
Whiteboard: [metro-mvp] [LOE:-] mc-merge → [metro-mvp] [LOE:-] mc-merge feature=work c=navigation_app_bar_autocomplete
Updated•12 years ago
|
Summary: Define search preferences in metrofx → Work - Define search preferences in metrofx
Whiteboard: [metro-mvp] [LOE:-] mc-merge feature=work c=navigation_app_bar_autocomplete → [mc-merge] feature=work
Comment 5•12 years ago
|
||
I've converted this to a story.
Story: as a Metro Firefox user, I have quick and easy access to search services including Bing, Google, Yahoo, and Wikipedia
Flow:
1. A Metro Firefox user opens a new tab, types in the string "moz" and sees a list of available search engines.
2. The user looks over the list and sees these services in this order
2a. Bing
2b. Google
2c. Yahoo
2d. Wikipedia
Blocks: 831671
Flags: needinfo?(asa)
Summary: Work - Define search preferences in metrofx → Story - Search defaults for v1
Whiteboard: [mc-merge] feature=work → [mc-merge] feature=story
Updated•12 years ago
|
Whiteboard: [mc-merge] feature=story → [mc-merge] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0
Updated•12 years ago
|
Priority: -- → P2
Updated•12 years ago
|
Reporter | ||
Updated•11 years ago
|
Whiteboard: [mc-merge] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [preview]
Reporter | ||
Updated•11 years ago
|
Updated•11 years ago
|
Summary: Story - Search defaults for v1 → [MP] Story - Search defaults for v1
Whiteboard: [preview] → [preview] feature=story c=tbd u=tbd p=0
Updated•11 years ago
|
Whiteboard: [preview] feature=story c=tbd u=tbd p=0 → [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0
Updated•11 years ago
|
Whiteboard: [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Whiteboard: [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=0 → [l10n] [preview] feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=1
Updated•11 years ago
|
QA Contact: jbecerra
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #804815 -
Flags: review?(jmathies)
Reporter | ||
Comment 7•11 years ago
|
||
This was originally assigned to Asa due to legal concerns. Did a final decision get made?
Assignee | ||
Comment 8•11 years ago
|
||
Reporter | ||
Comment 9•11 years ago
|
||
(In reply to Brian R. Bondy [:bbondy] from comment #8)
> Not sure, but Comment 5 defines a story to implement, so that's what I did :)
> Asa if no decision has been made here and Comment 5 is invalid, please feel
> free to re-take the bug.
Yeah I think this is on hold until legal decides exactly what metrofx is. :)
Assignee | ||
Comment 10•11 years ago
|
||
Alright, I seen that the bug needinfo'd Asa on 2013-04-08 and then he replied with a story a week later, so I assumed he had obtained he information he needed and had a story. I still think that may be the case, but I'll assign it to Asa to be sure.
Assignee: netzen → asa
Comment 11•11 years ago
|
||
Sorry I didn't get back sooner. We're good to go here with the story as written in comment 5.
Assignee | ||
Comment 13•11 years ago
|
||
Thanks for the quick reply.
Jim I have a change coming for a client=metrofirefox parameter, I just removed it in the last patch.
Assignee | ||
Comment 14•11 years ago
|
||
Attachment #804815 -
Attachment is obsolete: true
Attachment #804815 -
Flags: review?(jmathies)
Attachment #804824 -
Flags: review?(jmathies)
Reporter | ||
Comment 15•11 years ago
|
||
Comment on attachment 804815 [details] [diff] [review]
Patch v1.
WFM if Asa says the order is ok.
Attachment #804815 -
Flags: review+
Reporter | ||
Updated•11 years ago
|
Attachment #804824 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 16•11 years ago
|
||
Yep order matches what is given in the story:
Bing, Google, Yahoo, Wikipedia
But order is top to bottom, left to right so it looks like:
> Bing Yahoo
> Google Wikipedia
Since there is room for 2 on each column.
Assignee | ||
Comment 17•11 years ago
|
||
Comment on attachment 804824 [details] [diff] [review]
Patch v2.
Causing a test failure, will upload a new patch when fixed.
Attachment #804824 -
Flags: review+
Assignee | ||
Comment 18•11 years ago
|
||
Same as the last patch but when it's called for desktop front end it won't use metrolist.txt it'll use list.txt for the search plugins.
Attachment #804824 -
Attachment is obsolete: true
Attachment #805374 -
Flags: review?(jmathies)
Reporter | ||
Comment 19•11 years ago
|
||
Comment on attachment 805374 [details] [diff] [review]
Patch v3
Review of attachment 805374 [details] [diff] [review]:
-----------------------------------------------------------------
Is |client=metrofirefox| the right value? (I have no idea what this should be.)
Attachment #805374 -
Flags: review?(jmathies) → review+
Comment 20•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #19)
> Comment on attachment 805374 [details] [diff] [review]
> Patch v3
>
> Review of attachment 805374 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Is |client=metrofirefox| the right value? (I have no idea what this should
> be.)
I'll get an update from legal and if we need to change, we will. We should go ahead and land what we have.
Assignee | ||
Comment 21•11 years ago
|
||
Yep see comment 3.
Assignee | ||
Comment 22•11 years ago
|
||
oops just seen asa's last comment, yep I'll land it and re-update via another bug if needed.
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 23•11 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → Firefox 27
Comment 24•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 25•11 years ago
|
||
Verified as fixed, for iteration #15, with latest Nightly on Win 8 64-bit.
I get the same results as from comment 16.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 27•11 years ago
|
||
Comment on attachment 805374 [details] [diff] [review]
Patch v3
This is already landed but based on your feedback, if needed, I'll do a followup patch. Ms2ger let me know this should have been reviewed by a build peer. Thanks.
Attachment #805374 -
Flags: review?(khuey)
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(netzen)
Attachment #805374 -
Flags: review?(khuey) → review+
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•