Bug 790133 asserts due to BluetoothService::Get being called off the main thread, since it tries to access BluetoothService from the EventFilter, which runs on the Bluetooth DBus Signal thread.

Ok, so after calling BluetoothService::Get(), which starts with MOZ_ASSERT(NS_IsMainThread()), it's specifically calling GetDevicePropertiesInternal where the first line is MOZ_ASSERT(NS_IsMainThread()). Come on guys. Test your code in Debug please.

Title fixed.

Took the opportunity to do a little code cleanup too. Should condense the async generic getproperties call at some point too.

Comment on attachment 661972 [details] [diff] [review] Patch 1 (v2) - Move DeviceProperties fetching to a runnable dispatched to the main thread Review of attachment 661972 [details] [diff] [review]: ----------------------------------------------------------------- r+ after problem fixed. ::: dom/bluetooth/linux/BluetoothDBusService.cpp @@ +873,5 @@ > + MOZ_ASSERT(!NS_IsMainThread()); > + nsString replyError; > + DBusError err; > + dbus_error_init(&err); > + Nit: additional blanks here @@ +881,5 @@ > + NS_ConvertUTF16toUTF8(aPath).get(), > + aIface, > + "GetProperties", > + DBUS_TYPE_INVALID); > + if(aIface == DBUS_DEVICE_IFACE) { Nit: needs a blank behind 'if' @@ +891,5 @@ > + } else { > + NS_WARNING("Unknown interface for GetProperties!"); > + return false; > + } > + Nit: additional blanks here @@ +1363,5 @@ > NS_IMETHOD Run() > { > MOZ_ASSERT(!NS_IsMainThread()); > + BluetoothValue v; > + if(!GetPropertiesInternal(mDevicePath, DBUS_DEVICE_IFACE, v)) Nit: needs a blank behind 'if' @@ +1364,5 @@ > { > MOZ_ASSERT(!NS_IsMainThread()); > + BluetoothValue v; > + if(!GetPropertiesInternal(mDevicePath, DBUS_DEVICE_IFACE, v)) > + { Nit: open brace should be at the end of previous line @@ +1407,5 @@ > BluetoothValue values = InfallibleTArray<BluetoothNamedValue>(); > > for (int i = 0; i < mDeviceAddresses.Length(); i++) { > + BluetoothValue v; > + if(!GetPropertiesInternal(mDeviceAddresses[i], DBUS_DEVICE_IFACE, v)) Nit: needs a blank behind 'if' @@ +1408,5 @@ > > for (int i = 0; i < mDeviceAddresses.Length(); i++) { > + BluetoothValue v; > + if(!GetPropertiesInternal(mDeviceAddresses[i], DBUS_DEVICE_IFACE, v)) > + { Nit: open brace should be at the end of previous line @@ +1409,5 @@ > for (int i = 0; i < mDeviceAddresses.Length(); i++) { > + BluetoothValue v; > + if(!GetPropertiesInternal(mDeviceAddresses[i], DBUS_DEVICE_IFACE, v)) > + { > + NS_WARNING("Getting properties failed!"); I think we still need to do DispatchBluetoothReply() here?

Wouldn't want this to regress.