Here is some more low-hanging fruit keeping jsreftests from passing in root-analysis mode, mostly a bunch of JSScript* and UncachedCallResult. The next test is failing on the internal Shape* in bindings. That is going to take longer to fix, so this looked like a good place to cut the patch. I also removed the implicit TlsRuntime constructor for Rooted: I think if we want to use this we should force the caller to use TlsRuntime itself so that the users are easier to track.

Comment on attachment 662305 [details] [diff] [review] v0 Review of attachment 662305 [details] [diff] [review]: ----------------------------------------------------------------- Some of these changes give me the creepy-crawlies, but they all seem correct.

Pushed at: https://hg.mozilla.org/integration/mozilla-inbound/rev/e230091ecf66

Comment on attachment 662305 [details] [diff] [review] v0 Review of attachment 662305 [details] [diff] [review]: ----------------------------------------------------------------- > I also removed the implicit TlsRuntime constructor for Rooted Excellent! ::: js/src/methodjit/InvokeHelpers.cpp @@ +428,5 @@ > types::TypeScript::Monitor(f.cx, f.script(), f.pc(), args.rval()); > } > > void > +stubs::UncachedCallHelper(VMFrame &f, uint32_t argc, bool lowered, UncachedCallResult &ucr) Can you use |const UncachedCallResult &| instead?