Closed Bug 792421 Opened 12 years ago Closed 12 years ago

build failure in nsCookieService.h: "nsCookieService.h:72: error: cannot declare reference to ‘const class nsCookieKey&’"

Categories

(Core :: Networking: Cookies, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

It's not obvious to me why this is failing on my machine (gcc 4.4.5) and not on the builders, but it is definitely failing. Obvious patch on the way, assuming it finishes compiling fine.
Attached patch patch (deleted) — Splinter Review
Attachment #662557 - Flags: review?(jduell.mcbugs)
I am also seeing similar build errors on windows, and they are fixed by the patch https://bugzilla.mozilla.org/attachment.cgi?id=662557 My errors: c:\tb\1c-central\src\mozilla\netwerk\cookie\nsCookieService.h(72) : error C2529: 'other' : reference to reference is illegal c:\tb\1c-central\src\mozilla\netwerk\cookie\nsCookieService.h(72) : error C2228: left of '.mBaseDomain' must have class/struct/union type is 'nsCookieKey::KeyType' c:\tb\1c-central\src\mozilla\netwerk\cookie\nsCookieService.h(74) : error C2228: left of '.mAppId' must have class/struct/union type is 'nsCookieKey::KeyType' c:\tb\1c-central\src\mozilla\netwerk\cookie\nsCookieService.h(75) : error C2228: left of '.mInBrowserElement' must haveclass/struct/union type is 'nsCookieKey::KeyType'
Attachment #662557 - Flags: review?(jduell.mcbugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b780edad8cd (Build failures should probably land on central, but since this obviously isn't a problem for too many people, I don't see much wrong with putting in on inbound and letting a merge bring it in naturally.)
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: