Closed
Bug 793147
Opened 12 years ago
Closed 12 years ago
TBPL needs a toggle-able debug mode print/echo based on Timer.php
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Swatinem
:
review+
|
Details | Diff | Splinter Review |
For bug 790889 / bug 718632, I've had to scatter things like this around:
> if (PHP_SAPI === 'cli')
> echo "starting ".$log['type']." log generation\n";
It would be a lot nicer if we could adapt Timer.php to provide both timing and general debug info output, without the need to use a conditional every time.
(ie as suggested in bug 718632 comment 53)
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #663374 -
Flags: review?(arpad.borsos)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 663374 [details] [diff] [review]
Patch v1
Review of attachment 663374 [details] [diff] [review]:
-----------------------------------------------------------------
::: php/inc/Timer.php
@@ +6,3 @@
> static $enabled = false;
> + private $startTime;
> + public static function output($str) {
Good thing making it static :-)
Attachment #663374 -
Flags: review?(arpad.borsos) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
Not yet in production, but will be soon and I'm trying to clean up my assigned bugs searches.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•