Closed Bug 793150 Opened 12 years ago Closed 12 years ago

Firefox Menu should exit full screen mode

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox20 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 20
Tracking Flags:
Tracking Status
firefox20 --- verified

People

(Reporter: xti, Assigned: kats)

References

Details

Attachments

(1 file)

Patch
(deleted), patch
sriram
: review+
Details | Diff | Splinter Review
Firefox 18.0a1 (2012-09-20) Device: Galaxy Note OS: Android 4.0.4 Steps to reproduce: 1. Open Firefox for Android 2. Go to http://www.w3schools.com/html5/tryit.asp?filename=tryhtml5_video_all (http://goo.gl/JASX2) 3. Switch the video to full screen mode 4. Tap on Menu > Add-ons Expected result: Firefox Menu is not trigger while a video plays in full screen mode. Actual result: After step 4, the browser remains in full screen mode.
Might be fixed by bug 768887
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=768887
Summary: Firefox Menu should be disabled while a video plays in full screen mode → Firefox Address bar should be disabled while a video plays in full screen mode
Ignore comment 1. Wrong bug.
See Also: https://bugzilla.mozilla.org/show_bug.cgi?id=768887 →
Summary: Firefox Address bar should be disabled while a video plays in full screen mode → Firefox Menu should be disabled while a video plays in full screen mode
qawanted to retest. Is this specific to the Galaxy Note? On the Galaxy Nexus there's no menu button in full-screen mode. I don't have a Note or a tablet on hand right now to test that.
Keywords: qawanted
Flags: needinfo?(nicolae.cristian)
I can reproduce this issue on the latest Nightly build on Galaxy S2. Actually, this issue is reproducible on any devices similar to S2 or Note which have a dedicated Menu button. -- Firefox 20.0a1 (2012-11-26) Device: Galaxy S2 OS: Android 4.0.3
Flags: needinfo?(nicolae.cristian)
Keywords: qawanted
Ok, I can reproduce this. It also seems like there's no way to get out of fullscreen mode after step 4 in the original STR. (In reply to Cristian Nicolae (:xti) from comment #0) > Expected result: > Firefox Menu is not trigger while a video plays in full screen mode. However, I'm not sure this is the best solution from a UX point of view. Maybe automatically exit full-screen mode when the menu button is triggered? CC'ing ian for any thoughts here.
Seems like we need UX to weigh in here
Assignee: nobody → ibarlow
Keywords: uiwanted
We don't want people getting stuck in full screen mode. I would suggest that pressing any phone controls (back, menu) would pull the user out of full screen. Pressing back would exit full screen, and pressing menu (where available) would exit full screen and open the menu.
Thanks, Ian. I can implement this then.
Assignee: ibarlow → bugmail.mozilla
Keywords: uiwanted
Attached patch Patch (deleted) — — Splinter Review
Attachment #687160 - Flags: review?(sriram)
Comment on attachment 687160 [details] [diff] [review] Patch Review of attachment 687160 [details] [diff] [review]: ----------------------------------------------------------------- Beautiful.
Attachment #687160 - Flags: review?(sriram) → review+
Summary: Firefox Menu should be disabled while a video plays in full screen mode → Firefox Menu should exit full screen mode
https://hg.mozilla.org/mozilla-central/rev/2bf9b04dd7cf
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Pressing the Menu button will exit the video from full screen mode. Closing bug as verified fixed on: Firefox 20.0a1 (2012-12-03) Device: Galaxy S2 OS: Android 4.0.3
Status: RESOLVED → VERIFIED
status-firefox20: --- → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: