As per device certification requirements, we need to support MMI codes for entering, changing and unlocking of PIN and PIN2 codes.

Is this a P1 blockers or is it a nice-to-have?

(In reply to Andrew Overholt [:overholt] from comment #1) > Is this a P1 blockers or is it a nice-to-have? Blocker because device certification requirement.

I consider this task as LOE:S once bug 793186 lands

Now without trailing whitespaces.

Comment on attachment 669886 [details] [diff] [review] Part 1: RIL Review of attachment 669886 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, just two minor nits :) ::: dom/system/gonk/ril_worker.js @@ +2327,5 @@ > options.errorMsg = errorMsg; > this.sendDOMMessage(options); > }).bind(this); > > + let _isValidICCRequest = function _isValidICCRequest() { nit: does this need to be declared as a variable? (just using a named function should suffice, unless you meant to bind it?) also, this function name seems overly broad if you're only validating registration MMI procedures..

Comment on attachment 669885 [details] [diff] [review] Part 2: Tests Review of attachment 669885 [details] [diff] [review]: ----------------------------------------------------------------- \o/ for tests. Can you also add test case(s) for the new PINs being different (NEW_PIN_MISMATCH)? r=me with that

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8eb7dfe8678 https://hg.mozilla.org/integration/mozilla-inbound/rev/4807f1c1308e

https://hg.mozilla.org/mozilla-central/rev/c8eb7dfe8678 https://hg.mozilla.org/mozilla-central/rev/4807f1c1308e

https://hg.mozilla.org/releases/mozilla-aurora/rev/557a3f5164e6 https://hg.mozilla.org/releases/mozilla-aurora/rev/3a82fae11d50