Open
Bug 793477
Opened 12 years ago
Updated 2 years ago
Make JarMaker's chrome.manifest output line ending consistent with tests
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: rain1, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
JarMaker.py uses os.linesep for output:
https://mxr.mozilla.org/mozilla-central/source/config/JarMaker.py#180
But unit-JarMaker.py checks that the output is LF on all platforms:
https://mxr.mozilla.org/mozilla-central/source/config/tests/unit-JarMaker.py#267
This clearly needs to be reconciled.
Currently it works because Preprocessor.py clobbers os.linesep even if it isn't the main module. However I'm going to change that in bug 585012.
ccing ted and Pike.
|
Reporter | |
Comment 1•12 years ago
|
||
This makes our code reflect reality and lets tests pass.
Attachment #663792 -
Flags: review?(ted.mielczarek)
|
||
Updated•12 years ago
|
Attachment #663792 -
Flags: review?(ted.mielczarek) → review+
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•