Closed
Bug 793479
Opened 12 years ago
Closed 12 years ago
Rename AppProcessHasPermission to AssertAppProcessPermission
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: philikon, Assigned: cjones)
References
Details
Attachments
(1 file)
(deleted),
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
AppProcessHasPermission() does more than just a check and return a bool: it kills the content process if it doesn't have the permission that's being queried. The naming should reflect that. In bug 776832 we went with "assertPermission", so I'm proposing AssertAppProcessPermission().
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → philipp
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: philipp → jones.chris.g
Attachment #663796 -
Flags: review?(justin.lebar+bug)
Comment 2•12 years ago
|
||
Comment on attachment 663796 [details] [diff] [review]
Update C++ permission-checking API to match that of the message-manager one
> /**
> * Return true iff any of the PBrowsers loaded in this content process
> * has the specified capability.
> */
Can you update the comment here, too? (It's not clear to me that the comment
above applies here, since this one also has an explicit comment.)
> bool
>-AppProcessHasPermission(mozilla::dom::PContentParent* aActor,
>- const char* aPermission);
>+AssertAppProcessPermission(mozilla::dom::PContentParent* aActor,
>+ const char* aPermission);
Attachment #663796 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Sure.
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•