Closed
Bug 793533
Opened 12 years ago
Closed 11 years ago
Valgrind on tbpl detects leak at malloc (392 or 1,368 bytes in 1 blocks are definitely lost) with xpc::CreateGlobalObject on the stack
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: gkw, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: memory-leak, valgrind)
Attachments
(2 files, 2 obsolete files)
Valgrind detects a leak of 392 bytes at malloc with xpc_CreateGlobalObject on the stack, see attached snippet which comes from:
https://tbpl.mozilla.org/php/getParsedLog.php?id=15457865&tree=Firefox&full=1
Reporter | ||
Updated•12 years ago
|
Blocks: valgrind-on-tbpl
Reporter | ||
Updated•12 years ago
|
Hardware: All → x86_64
Line numbers would be useful here :-/
Reporter | ||
Updated•12 years ago
|
Blocks: valgrind-tbpl-bugs
Reporter | ||
Updated•12 years ago
|
No longer blocks: valgrind-on-tbpl
Reporter | ||
Comment 2•12 years ago
|
||
Attachment #663860 -
Attachment is obsolete: true
Reporter | ||
Comment 3•12 years ago
|
||
> Line numbers would be useful here :-/
We now have line numbers. For example,
http://hg.mozilla.org/mozilla-central/file/ca4af4af5334/js/xpconnect/src/XPCWrappedNative.cpp#l320
seems to point correctly to the call to xpc_CreateGlobalObject.
Reporter | ||
Comment 4•12 years ago
|
||
This one is 64-bit only. This appeared in the following window:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=85dd8e346102&tochange=635fcc11d2b1
Reporter | ||
Comment 5•12 years ago
|
||
> This one is 64-bit only. This appeared in the following window:
>
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=85dd8e346102&tochange=635fcc11d2b1
Bobby, Ms2ger, is bug 795300 likely the cause?
Comment 6•12 years ago
|
||
No. Bug 793116 is ever so slightly more likely, but even that shouldn't have caused leaks.
Comment 7•12 years ago
|
||
Could I have broken <https://hg.mozilla.org/mozilla-central/file/965f6dc789be/build/valgrind/cross-architecture.sup#l57> with the rename, though?
Reporter | ||
Comment 8•12 years ago
|
||
(In reply to :Ms2ger from comment #7)
> Could I have broken
> <https://hg.mozilla.org/mozilla-central/file/965f6dc789be/build/valgrind/
> cross-architecture.sup#l57> with the rename, though?
Possibly. I'll land a fix to remove that and see if it still shows up again.
Reporter | ||
Comment 9•12 years ago
|
||
> Possibly. I'll land a fix to remove that and see if it still shows up again.
https://hg.mozilla.org/mozilla-central/rev/1a2f506b1a92
Reporter | ||
Updated•12 years ago
|
Summary: Valgrind on tbpl detects leak at malloc (392 bytes in 1 blocks are definitely lost) with xpc_CreateGlobalObject on the stack → Valgrind on tbpl detects leak at malloc (392 bytes in 1 blocks are definitely lost) with xpc::CreateGlobalObject on the stack
Reporter | ||
Updated•12 years ago
|
Attachment #664983 -
Attachment is obsolete: true
Reporter | ||
Updated•12 years ago
|
Summary: Valgrind on tbpl detects leak at malloc (392 bytes in 1 blocks are definitely lost) with xpc::CreateGlobalObject on the stack → Valgrind on tbpl detects leak at malloc (392 or 1,368 bytes in 1 blocks are definitely lost) with xpc::CreateGlobalObject on the stack
Reporter | ||
Comment 10•12 years ago
|
||
Valgrind also detected a leak of 1,368 bytes (direct) with xpc::CreateGlobalObject on the stack, see attached snippet which comes from:
https://tbpl.mozilla.org/php/getParsedLog.php?id=17064538&tree=Firefox&full=1
m-c changeset rev is a761bfc192b5.
It didn't happen in the previous Valgrind run here: https://tbpl.mozilla.org/?noignore=1&jobname=valgrind&rev=dd68409d7810
So I'm guessing the regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dd68409d7810&tochange=a761bfc192b5
Comment 11•11 years ago
|
||
This is no longer occurring in Valgrind-on-TBPL runs. I think this one was a false positive due to the storing of pointers as js::Values, as fixed by bug 940069.
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•