Closed Bug 793739 Opened 12 years ago Closed 12 years ago

mirror mozbase to m-c for week of Sept 24, 2012

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: k0scist, Assigned: emorley)

References

Details

Attachments

(1 file, 2 obsolete files)

mozilla-central should be updated with changes to mozbase on github
Attached patch 5c80d19e721c4208d1136d4fabf239d4ebff5242 (obsolete) (deleted) — Splinter Review
Attachment #664173 - Flags: review?(wlachance)
killing try run as we'll also want bug 790595 as part of this (just landed)
Attached patch 6fea6006e9e7afaa4f9b7563c106961f0795e658 (obsolete) (deleted) — Splinter Review
Attachment #664173 - Attachment is obsolete: true
Attachment #664173 - Flags: review?(wlachance)
Attachment #664180 - Flags: review?(wlachance)
Blocks: 790595
Comment on attachment 664180 [details] [diff] [review] 6fea6006e9e7afaa4f9b7563c106961f0795e658 If this is just the output of the automated mirror script and it passes try, I don't have any problems with it.
Attachment #664180 - Flags: review?(wlachance) → review+
Really sorry for further churn in this bug; only difference is this includes the final tweak to bug 790595 (minor string changes to devicemanagerSUT.py: https://bugzilla.mozilla.org/attachment.cgi?id=664398&action=diff), which will prevent the odd unnecessary RETRY in production. Sent to try (android-only as the changes since the last try run are only in devicemanagerSUT.py): https://tbpl.mozilla.org/?tree=Try&rev=450ad8640ba7
Attachment #664180 - Attachment is obsolete: true
Attachment #664502 - Flags: review?(jhammel)
Comment on attachment 664502 [details] [diff] [review] b12b008846bc14744d43899ab356f5441e2416ea superficially, this looks fine, so I'm going to trust this one. it is really hard to review after the reindentation of all the things though :/
Attachment #664502 - Flags: review?(jhammel) → review+
You can also look at the github compare view to see the commits one by one: https://github.com/mozilla/mozbase/compare/mozilla-central...HEAD
Assignee: nobody → bmo
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Thank you :-)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: