Closed
Bug 793739
Opened 12 years ago
Closed 12 years ago
mirror mozbase to m-c for week of Sept 24, 2012
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: k0scist, Assigned: emorley)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
mozilla-central should be updated with changes to mozbase on github
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #664173 -
Flags: review?(wlachance)
Reporter | ||
Comment 2•12 years ago
|
||
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=cc27b1e72371
Reporter | ||
Comment 3•12 years ago
|
||
killing try run as we'll also want bug 790595 as part of this (just landed)
Reporter | ||
Comment 4•12 years ago
|
||
Attachment #664173 -
Attachment is obsolete: true
Attachment #664173 -
Flags: review?(wlachance)
Attachment #664180 -
Flags: review?(wlachance)
Comment 5•12 years ago
|
||
Comment on attachment 664180 [details] [diff] [review]
6fea6006e9e7afaa4f9b7563c106961f0795e658
If this is just the output of the automated mirror script and it passes try, I don't have any problems with it.
Attachment #664180 -
Flags: review?(wlachance) → review+
Reporter | ||
Comment 6•12 years ago
|
||
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=eadc60056069
Assignee | ||
Comment 7•12 years ago
|
||
Really sorry for further churn in this bug; only difference is this includes the final tweak to bug 790595 (minor string changes to devicemanagerSUT.py: https://bugzilla.mozilla.org/attachment.cgi?id=664398&action=diff), which will prevent the odd unnecessary RETRY in production.
Sent to try (android-only as the changes since the last try run are only in devicemanagerSUT.py):
https://tbpl.mozilla.org/?tree=Try&rev=450ad8640ba7
Attachment #664180 -
Attachment is obsolete: true
Attachment #664502 -
Flags: review?(jhammel)
Reporter | ||
Comment 8•12 years ago
|
||
Comment on attachment 664502 [details] [diff] [review]
b12b008846bc14744d43899ab356f5441e2416ea
superficially, this looks fine, so I'm going to trust this one. it is really hard to review after the reindentation of all the things though :/
Attachment #664502 -
Flags: review?(jhammel) → review+
Comment 9•12 years ago
|
||
You can also look at the github compare view to see the commits one by one: https://github.com/mozilla/mozbase/compare/mozilla-central...HEAD
Reporter | ||
Comment 10•12 years ago
|
||
Comment 11•12 years ago
|
||
Assignee: nobody → bmo
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Reporter | ||
Comment 12•12 years ago
|
||
Assignee | ||
Comment 13•12 years ago
|
||
Thank you :-)
You need to log in
before you can comment on or make changes to this bug.
Description
•