Closed Bug 793875 Opened 12 years ago Closed 12 years ago

roll our own URL parser for file:// URLs

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: k0scist, Unassigned)

References

Details

(Whiteboard: [mozfile][mozbase])

Attachments

(1 file)

see https://bugzilla.mozilla.org/show_bug.cgi?id=791884#c11 >>> import urlparse >>> results_url = >>> 'file://C:\Users\jhammel\mozharness\src\mozharness\build\jetpe rf.txt' >>> results_url_split = urlparse.urlsplit(results_url) >>> results_url_split SplitResult(scheme='file', >>> netloc='C:\\Users\\jhammel\\mozharness\\src\\mozharne ss\x08uild\\jetperf.txt', path='', query='', fragment='') So apparently windows paths aren't parsed the same as unix paths o_O . Though now that I say that it does sound strikingly familiar. In unix, the path goes in the (you guessed it) 'path' part of the segment just as God Intended. Sadly, I think the solution is to parse our own damn file:// urls. This sounds like a job for mozfile.
Whiteboard: [mozfile][mozbase]
Blocks: 791884
Attached patch roll our own urlsplit (deleted) — Splinter Review
Attachment #664259 - Flags: review?(jmaher)
Comment on attachment 664259 [details] [diff] [review] roll our own urlsplit Review of attachment 664259 [details] [diff] [review]: ----------------------------------------------------------------- good fix.
Attachment #664259 - Flags: review?(jmaher) → review+
this looks green enough, pushed to talos: http://hg.mozilla.org/build/talos/rev/74a2aed9f609
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 801633
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: