Closed
Bug 793875
Opened 12 years ago
Closed 12 years ago
roll our own URL parser for file:// URLs
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
References
Details
(Whiteboard: [mozfile][mozbase])
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
see https://bugzilla.mozilla.org/show_bug.cgi?id=791884#c11
>>> import urlparse
>>> results_url =
>>> 'file://C:\Users\jhammel\mozharness\src\mozharness\build\jetpe
rf.txt'
>>> results_url_split = urlparse.urlsplit(results_url)
>>> results_url_split
SplitResult(scheme='file',
>>> netloc='C:\\Users\\jhammel\\mozharness\\src\\mozharne
ss\x08uild\\jetperf.txt', path='', query='', fragment='')
So apparently windows paths aren't parsed the same as unix paths o_O
. Though now that I say that it does sound strikingly familiar. In
unix, the path goes in the (you guessed it) 'path' part of the segment
just as God Intended.
Sadly, I think the solution is to parse our own damn file:// urls.
This sounds like a job for mozfile.
Reporter | ||
Updated•12 years ago
|
Whiteboard: [mozfile][mozbase]
Reporter | ||
Comment 1•12 years ago
|
||
this also fixes https://bugzilla.mozilla.org/show_bug.cgi?id=755929
Attachment #664259 -
Flags: review?(jmaher)
Comment 2•12 years ago
|
||
Comment on attachment 664259 [details] [diff] [review]
roll our own urlsplit
Review of attachment 664259 [details] [diff] [review]:
-----------------------------------------------------------------
good fix.
Attachment #664259 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 3•12 years ago
|
||
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e3c1632e839c
Reporter | ||
Comment 4•12 years ago
|
||
this looks green enough, pushed to talos: http://hg.mozilla.org/build/talos/rev/74a2aed9f609
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•