Closed Bug 793906 Opened 12 years ago Closed 12 years ago

disable desktop support while we get B2G going.

Categories

(Core Graveyard :: Identity, enhancement)

Product:
Core Graveyard
Component:
Identity
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: benadida, Assigned: jedp)

References

Details

Attachments

(1 file)

suppress native identity on desktop
(deleted), patch
benadida
: review+
Details | Diff | Splinter Review
Some tweaks for B2G will surely bust the desktop builds, so let's disable it for anything other than B2G.
Assignee: nobody → jparsons
It's disabled by default so I guess disabling the tests would be the main thing. If we really need to disable the desktop UI, commenting out the bodies of SignInToWebsiteUX_init and SignInToWebsiteUX_uninit should cover most, if not all, of it.
Blocks: 793909
Blocks: 793911
No longer blocks: 793911
No longer blocks: 793909
Thanks also, Matt, for the additional suggestion you made on irc that we should comment this out: https://mxr.mozilla.org/mozilla-central/source/browser/modules/test/Makefile.in#17 I like this approach. Very easy to switch things back on again.
Comment on attachment 665646 [details] [diff] [review] suppress native identity on desktop Review of attachment 665646 [details] [diff] [review]: ----------------------------------------------------------------- looks good to me
Attachment #665646 - Flags: review?(benadida) → review+
https://hg.mozilla.org/mozilla-central/rev/0f552864888a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
navigator.id is not disabled in 19.0a1 (2012-10-31) on OSX when pref dom.identity.enabled is true.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The DOM code will run but the UI should be disabled. The pref is for the DOM code. Is that not what you're seeing? Is this a problem?
Hmm, so, yes, the native navigator.id is available, but the UI is disabled. I really think native navigator.id should not be available though.
Well, it's not available by default. The user would have to flip the pref to use it and we haven't widely told people to do so.
John: I think this is sufficiently disabled as far as I meant it when I opened the bug originally. I'm hoping you're okay with me re-closing it :)
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Depends on: 928579
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: