Closed
Bug 794412
Opened 12 years ago
Closed 12 years ago
Update gonk-toolchain to support building OMX-in-gecko
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: cjones, Assigned: cjones)
References
Details
Attachments
(2 files)
(deleted),
patch
|
jhford
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
I thought this would be trivial but it's turning into a tar baby. Fighting some C++ includes right now.
The toolchain produced from this work won't be publicly publishable (sigh), so we'll have to choose how the bits are pushed around. It's fine for them to live on mozilla servers that aren't publicly accessibly (like OS X, windows, etc.).
Assignee | ||
Comment 1•12 years ago
|
||
Could do a PR, but this is mostly to exchange information for now. This could land upstream a month from now.
Assignee: nobody → jones.chris.g
Attachment #664893 -
Flags: review?(jhford)
Assignee | ||
Comment 2•12 years ago
|
||
The includes from stlport/ conflict with some from ndk/. We need to include some of the stlport dirs directly, but we also need jni.h for the omx code here, which is brought in through ndk/. It's not wise to let ndk and stlport fight over their headers, so instead we just directly include what we need. There's no reason a priori that the stlport directory layout would change more than the ndk's.
This patch should allow both versions of the toolchain to work until we move to the new one.
Attachment #664901 -
Flags: review?(chris.double)
Updated•12 years ago
|
Attachment #664901 -
Flags: review?(chris.double) → review+
Comment 3•12 years ago
|
||
Could you explain what this bug actually means?
Assignee | ||
Comment 4•12 years ago
|
||
We need to build a new toolchain to support building OMX-decoder-built-into-gecko (bug 759506). Unfortunately, this also requires a gecko patch.
Blocks: 759506
Updated•12 years ago
|
Attachment #664893 -
Flags: review?(jhford) → review+
Assignee | ||
Comment 5•12 years ago
|
||
I confirmed with the patch here, m-c builds without bug 759506, and with the new toolchain applied it also builds.
Assignee | ||
Comment 6•12 years ago
|
||
Update to toolchain script landed as
https://github.com/mozilla-b2g/B2G/commit/ef94806c26af676c296884cc6732cb665800b1f1
and the configure.in patch to support both versions landed as
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dfca392c32b
Comment 7•12 years ago
|
||
Pointing at new b2g-toolchain on mozilla-central:
https://hg.mozilla.org/mozilla-central/rev/bb0d5695896d
Green on try
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•