Closed
Bug 794880
Opened 12 years ago
Closed 12 years ago
[Mac] The icon of the "Add Contact" and "Join Chat" toolbar buttons disappear when they are clicked while disabled
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird17 fixed)
RESOLVED
FIXED
Thunderbird 18.0
| Tracking | Status | |
|---|---|---|
| thunderbird17 | --- | fixed |
People
(Reporter: florian, Assigned: Paenglab)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
andreasn
:
review+
andreasn
:
ui-review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
This is a regression from bug 709799.
The CSS code in http://hg.mozilla.org/comm-central/annotate/f909272fc02a/mail/themes/pinstripe/mail/chat.css#l101 looks like this:
101 #button-join-chat {
102 list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
103 -moz-image-region: rect(0px 36px 18px 18px);
104 }
105
106 #button-join-chat:hover:active {
107 list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
108 -moz-image-region: rect(32px 64px 64px 32px);
109 }
110
111 #button-join-chat:not([disabled="true"]):active {
112 list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
113 -moz-image-region: rect(18px 36px 36px 18px);
114 }
I think the problem is that the second rule is applied even when the button is disabled.
Also, not that the lines 107 and 112 are pointless duplication here (and this duplication also exists for the Windows and Linux themes).
|
Assignee | |
Comment 1•12 years ago
|
||
This rules should be removed in patch for bug 709799.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #665616 -
Flags: ui-review?(nisses.mail)
Attachment #665616 -
Flags: review?(nisses.mail)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 665616 [details] [diff] [review]
patch
Code and ui looks good!
Attachment #665616 -
Flags: ui-review?(nisses.mail)
Attachment #665616 -
Flags: ui-review+
Attachment #665616 -
Flags: review?(nisses.mail)
Attachment #665616 -
Flags: review+
|
Reporter | |
Comment 3•12 years ago
|
||
Comment on attachment 665616 [details] [diff] [review]
patch
[Approval Request Comment]
I think we can take this simple patch for Thunderbird 17 (but I wouldn't be too upset if we don't).
Attachment #665616 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
|
||
Updated•12 years ago
|
Attachment #665616 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
Reporter | |
Comment 5•12 years ago
|
||
status-thunderbird17:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•