Closed
Bug 794966
Opened 12 years ago
Closed 12 years ago
pymake treats environment variables as := assignments
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Consider the following Makefile: FOO += $(BAR) BAR := bar foo: @echo $(FOO) FOO=foo make -f test.mk outputs "foo bar" (while make -f test.mk FOO=foo output "foo") pymake outputs "foo". The real life case is that we export DLLFLAGS in security/build/Makefile.in, and security/coreconf/WIN32.mk appends -OUT="$@" to it. So the value ends up being whatever was exported + -OUT="", which fails to build.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #665486 -
Flags: review?(ted.mielczarek)
Updated•12 years ago
|
Attachment #665486 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a3024f9a744
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5a3024f9a744
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•