Closed Bug 794978 Opened 12 years ago Closed 6 years ago

Always delete app's cookies even if the cookies have not been loaded yet

Categories

(Core :: Networking: Cookies, defect, P5)

Product:
Core
Component:
Networking: Cookies
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Project Flags:
blocking-basecamp -

People

(Reporter: mounir, Assigned: jduell.mcbugs)

References

Details

(Whiteboard: [necko-would-take])

See: https://bugzilla.mozilla.org/show_bug.cgi?id=783408#c33 Seems that "cookie-db-read" notification is fired when the cookies are all loaded. We could maybe initialize the service if not running yet and then wait for that event to do the actual removal. We might want to block on that (as a bug fix) because if no network connection is created and a user tries to delete the data of an app/browser, we might end up with the data not being deleted.
(In reply to Mounir Lamouri (:mounir) from comment #0) > We might want to block on that (as a bug fix) because if no network > connection is created and a user tries to delete the data of an app/browser, > we might end up with the data not being deleted. Sounds like a blocker. I clarified the summary, please fix if I did it incorrectly :)
blocking-basecamp: ? → +
Summary: Do not try to remove app's cookies if the cookies have not been loaded yet → Always delete app's cookies even if the cookies have not been loaded yet
Mounir, please let us know if you don't have time for this.
Assignee: nobody → mounir
Not sure this is actually much of a risk in practice, but I have ideas on how to fix.
Assignee: mounir → jduell.mcbugs
Is this really a basecamp blocker if the practical risk is low?
I don't think we should only consider the chances that this bug actually happens. We should take into consideration the consequences of the bug also. IMO, the consequences are not minor.
Priority: -- → P2
Priority: P2 → P3
Are you still working on this, Jason?
Flags: needinfo?(jduell.mcbugs)
It's not the first thing on my TODO list, but it's on it.
Flags: needinfo?(jduell.mcbugs)
See bug 810209: I'm proposing that we do that instead of this for B2G v1
blocking-basecamp: + → ?
Cool, let's fix this bug that way instead.
blocking-basecamp: ? → -
Depends on: 810209
Is this fixed entirely by bug 810209? Sounds like still a little racy, but y'all would know for sure.
Flags: needinfo?(jduell.mcbugs)
I'm not worried about correctness/raciness. At this point the cookie deletion thing works, but is an inefficient hack (mounir coded it to evict each of an app's cookies, one by one, which is a lot less efficient than just doing a SQL "delete where appId=XYZ"). So I'm leaving this bug open for technical debt (and I guess perf, though I'd be surprised if any app but a browser would see any really large delay).
Flags: needinfo?(jduell.mcbugs)
Ok, so the patch to close this would be more efficient cookie eviction on app uninstall? Anything else?
Whiteboard: [necko-would-take]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P3 → P5
B2G bug
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.