Closed
Bug 795135
Opened 12 years ago
Closed 12 years ago
[Azure] Cairo paths helper not restoring transforms
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: ajones, Assigned: ajones)
References
Details
Attachments
(1 file)
(deleted),
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
The cairo path helper CairoTempMatrix doesn't restore matrices as it should.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #665670 -
Flags: review?(joe)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ajones
Comment 2•12 years ago
|
||
Comment on attachment 665670 [details] [diff] [review]
Fix CairoTempMatrix restore
Review of attachment 665670 [details] [diff] [review]:
-----------------------------------------------------------------
tears and weeping
Attachment #665670 -
Flags: review?(joe) → review+
Comment 3•12 years ago
|
||
Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 90 total builds):
success: 80
warnings: 10
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-7c4a2915b413
Comment 4•12 years ago
|
||
Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 94 total builds):
success: 83
warnings: 11
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-7c4a2915b413
Comment 5•12 years ago
|
||
Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 95 total builds):
success: 83
warnings: 12
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-7c4a2915b413
Comment 6•12 years ago
|
||
Try run for 7c4a2915b413 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=7c4a2915b413
Results (out of 97 total builds):
success: 84
warnings: 13
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-7c4a2915b413
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 7•12 years ago
|
||
Green on Try.
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa73f5544e07
Should this have a test?
Flags: in-testsuite?
Keywords: checkin-needed
Comment 8•12 years ago
|
||
IIRC it broke existing tests when azure content was turned on.
Updated•12 years ago
|
Flags: in-testsuite? → in-testsuite-
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment 10•12 years ago
|
||
It turns out that this is what regressed a few Canvas 2D tests, like
http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.transform.2.html
on various platforms. Bisection found
changeset: 108853:aa73f5544e07
user: Anthony Jones <ajones@mozilla.com>
date: Mon Oct 01 22:12:13 2012 -0400
summary: Bug 795135 - Fix CairoTempMatrix restore. r=joe
Again I apologize for having accidentally disabled canvas tests for a few weeks. They are reenabled now, but with these few sub-tests commented out. See bug 800658.
Blocks: 800658
Updated•12 years ago
|
Comment 11•12 years ago
|
||
Anthony, I'm not really competent to debug this. Can I ask you to take care of it?
You need to log in
before you can comment on or make changes to this bug.
Description
•