Closed
Bug 79516
Opened 23 years ago
Closed 23 years ago
File type description contains garbage characters when initiating download on non-English OS
Categories
(SeaMonkey :: UI Design, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: jonrubin, Assigned: tetsuroy)
References
()
Details
(Keywords: intl, Whiteboard: /r=ftang, /sr=ben and alecf, /a=asa. Checked-in.)
Attachments
(4 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Trunk build 2001050406. Found on WinMe-Ja.
When downloading a file, the first sentence in the download dialog window says
"You have chosen to download a file of type:". If downloading on a non-English
system such as Japanese WinMe, this sentence is immediately followed by garbage
characters. To reproduce:
1) Go to a download site, such as download.cnet.com/downloads.
2) Initiate a download. The download dialogue window will open; the garbage
characters appear as described above.
Comment 1•23 years ago
|
||
Please attach a screen shot.
Comment 4•23 years ago
|
||
Reassign to pchen, cc to av.
Comment 5•23 years ago
|
||
Changing QA contact to jonrubin@netscape.com.
QA Contact: andreasb → jonrubin
Comment 6•23 years ago
|
||
Paul - Why is this future? Pls consider for M0.9.1, but it should definitely be
fixed by M0.9.2.
Comment 7•23 years ago
|
||
Adding Vishy to cc: list. Vishy - This doesn't look good. Why is it marked
Future, and not MO.9.2?
Marking as RTM and nscatfood, because I don't think we should ship a product
this way. The user can not tell what they are downloading. In the world of
viruses, i would not be secure using this product.
Comment 8•23 years ago
|
||
Per Monday's PDT, we believe this should be fixed for RTM. Moving to M0.9.2 |
P2.
Severity: normal → major
Priority: -- → P2
Target Milestone: Future → mozilla0.9.2
Updated•23 years ago
|
Comment 9•23 years ago
|
||
Frank, we may need help to reproduce this with a debug build on a Japanese OS
system. No one in my group has a Japanese system. Could someone in your group
take this bug? thanks, Vishy
Updated•23 years ago
|
Whiteboard: need intl group help
Assignee | ||
Comment 10•23 years ago
|
||
Assignee | ||
Comment 11•23 years ago
|
||
pchen: can you you assign this bug to me? Vishy, Frank and myself
talked yesterday with regard to this bug. Thank you.
Comment 12•23 years ago
|
||
-> yokoyama. Thanks for taking & fixing this! Is there similar change needed for
other OS (Mac/Linux) or will this be windows only. Paul can you r= the patch.
Assignee: pchen → yokoyama
Assignee | ||
Comment 13•23 years ago
|
||
Assignee | ||
Comment 14•23 years ago
|
||
>Is there similar change needed for
>other OS (Mac/Linux)
Potentially in other platforms as well,
but by quickly looking at Unix and Mac files
they seems ok. We may want to confirm this
with iQA for respective platforms.
Andreas, can check?
>will this be windows only.
Yes, this fix is windows only.
I posted a better patch (adding NULL terminator to Unicode string)
Status: NEW → ASSIGNED
Assignee | ||
Updated•23 years ago
|
Whiteboard: need intl group help → waiting for /r=
Assignee | ||
Comment 15•23 years ago
|
||
Assignee | ||
Comment 16•23 years ago
|
||
ftang: thanks for checking my code. Please review. thanks
Comment 17•23 years ago
|
||
r=ftang
Updated•23 years ago
|
Whiteboard: waiting for /r= → ask alecf to sr= 13:15 6/19
Updated•23 years ago
|
Whiteboard: ask alecf to sr= 13:15 6/19 → wait for a= 15:36 6/19
Comment 19•23 years ago
|
||
sr=alecf
Comment 20•23 years ago
|
||
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Blocks: 83989
Assignee | ||
Comment 21•23 years ago
|
||
checked-in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: wait for a= 15:36 6/19 → /r=ftang, /sr=ben and alecf, /a=asa. Checked-in.
Reporter | ||
Comment 22•23 years ago
|
||
VERIFIED in 062506 Trunk build using WinMe-Ja.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•