George Wright (:gw280) (needinfo me!) Reporter
	Description • 12 years ago

Currently, BACKEND_SKIA is only added to the allowable backends bitmask if direct2d is disabled. I think we should allow Skia to be usable on machines that are accelerated as well.

	George Wright (:gw280) (needinfo me!) Reporter
	Comment 2 • 12 years ago

Oh, hrm, text doesn't currently work in Skia/Canvas if Direct2D is enabled.

	George Wright (:gw280) (needinfo me!) Reporter
	Comment 4 • 8 years ago
mozreview-review

Comment on attachment 8818734 [details]
Bug 795627: Allow Skia canvas with accelerated Windows.

https://reviewboard.mozilla.org/r/98686/#review99016

	Milan Sreckovic [:milan] (needinfo for best results) Assignee
	Comment 5 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=790ec47c7196f041a8461f43b4763355ab23068e

	Milan Sreckovic [:milan] (needinfo for best results) Assignee
	Comment 6 • 8 years ago

(In reply to Milan Sreckovic [:milan] from comment #5)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=790ec47c7196f041a8461f43b4763355ab23068e

A couple of intermittent oranges, I don't imagine would get more frequent with this patch.

	Pulsebot
	Comment 7 • 8 years ago

Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11e2a07abdaa
Allow Skia canvas with accelerated Windows. r=gw280

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 8 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/11e2a07abdaa

	Andrei Vaida [:avaida]
	Comment 9 • 8 years ago

Milan, does this fix have automated coverage? Would it benefit from manual testing as well?

	Milan Sreckovic [:milan] (needinfo for best results) Assignee
	Comment 10 • 8 years ago

There are automated tests, but I don't think we run this configuration by default, so doing manual testing may be useful.  Kats, can you do a try push with the preference disabling D2D content/canvas, just to see if something unexpected is happening?  Still with the accelerated compositor.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 11 • 8 years ago

I think this should do it:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c4a4c042d2db1609e0b07e777f001fc028ec843

Leaving needinfo on me until the try push is done.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 12 • 8 years ago

Try results are in. There's gpu job failures, but that's expected (it's asserting D2D is on but it's not). And then there's a handful of WPT tests that are passing instead of failing, so those jobs are failing with TEST-UNEXPECTED-PASS. There's one test which changed from a pass to a fail. I haven't looked at the tests so I'm not sure what they're doing, but overall it doesn't seem like there's a lot of unexpected bustage.