Open
Bug 795811
Opened 12 years ago
Updated 2 years ago
Make GetPrimaryScrollableLayer() return null on all configurations except MOZ_WIDGET_ANDROID
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
NEW
People
(Reporter: cjones, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
See bug 790508. This is a bad assumption that just burned us.
assign -> dz to do the honors.
|
||
Comment 1•12 years ago
|
||
Attachment #666629 -
Flags: review?(jones.chris.g)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 666629 [details] [diff] [review]
Patch
>From: David Zbarsky <dzbarsky@gmail.com>
>Bug 795811 - Make GetPrimaryScrollableLayer() return null on all configurations except MOZ_WIDGET_ANDROID r=cjones
>
>diff --git a/gfx/layers/Layers.cpp b/gfx/layers/Layers.cpp
> // LayerManager
> Layer*
> LayerManager::GetPrimaryScrollableLayer()
> {
>+
Remove this newline.
>+#ifndef MOZ_WIDGET_ANDROID
>+ return nullptr;
Add a comment why this method is fennec-android-specific.
Attachment #666629 -
Flags: review?(jones.chris.g) → review+
|
|
||
Comment 3•12 years ago
|
||
Flags: in-testsuite-
|
|
Reporter | |
Comment 4•12 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Once we switch fennec to APZ we can just get rid of GetPrimaryScrollableLayer entirely.
Depends on: apz-fennec
|
||
Comment 6•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: dzbarsky → nobody
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•