Closed
Bug 796065
Opened 12 years ago
Closed 12 years ago
[markup panel] Any un-expanded node with content should show a "..." between open and close tags
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: harth, Assigned: Optimizer)
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
Optimizer
:
review+
|
Details | Diff | Splinter Review |
To show that there's content in a node without needing to expand it, we should indicate with a "...", like Chrome. It should be a grey or something that's not the same color as text content. <div class="content">...</div>
Assignee | ||
Comment 1•12 years ago
|
||
using an ellipses with surrounding space, as simply using ellipses was too narrow. IMO, "..." feels better, but not sure to use that or not.
Updated•12 years ago
|
Attachment #703329 -
Flags: review?(paul) → review?(dcamp)
Comment 2•12 years ago
|
||
Comment on attachment 703329 [details] [diff] [review] patch v1.0 Review of attachment 703329 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/markupview/MarkupView.jsm @@ +787,5 @@ > + this.editor.summaryElt.addEventListener("click", function(evt) { > + this.markup.navigate(this); > + > + if (this.expanded) { > + this.markup.collapseNode(this.node); Is this ever going to happen? The summary element is hidden when expanded, no? @@ +837,5 @@ > this.expander.setAttribute("expanded", ""); > this.children.setAttribute("expanded", ""); > + if (this.editor.summaryElt) { > + this.editor.summaryElt.style.display = "none"; > + } The other nodes here use an expanded attribute with a :not([expanded]) rule in markup-view.css. I don't particularly care whether we use direct manipulation or attribute+style here, but would be nice to be consistent.
Attachment #703329 -
Flags: review?(dcamp)
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Dave Camp (:dcamp) from comment #2) > Comment on attachment 703329 [details] [diff] [review] > patch v1.0 > > Review of attachment 703329 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/devtools/markupview/MarkupView.jsm > @@ +787,5 @@ > > + this.editor.summaryElt.addEventListener("click", function(evt) { > > + this.markup.navigate(this); > > + > > + if (this.expanded) { > > + this.markup.collapseNode(this.node); > > Is this ever going to happen? The summary element is hidden when expanded, > no? > > @@ +837,5 @@ > > this.expander.setAttribute("expanded", ""); > > this.children.setAttribute("expanded", ""); > > + if (this.editor.summaryElt) { > > + this.editor.summaryElt.style.display = "none"; > > + } > > The other nodes here use an expanded attribute with a :not([expanded]) rule > in markup-view.css. I don't particularly care whether we use direct > manipulation or attribute+style here, but would be nice to be consistent. Agreed on both. reattaching.
Assignee | ||
Comment 4•12 years ago
|
||
comments addressed.
Attachment #703329 -
Attachment is obsolete: true
Attachment #703391 -
Flags: review?(dcamp)
Updated•12 years ago
|
Attachment #703391 -
Flags: review?(dcamp) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 5•12 years ago
|
||
Before landing, please make a note that this patch uses " … " instead of "...". I personally like "..." though :)
Comment 6•12 years ago
|
||
Why is this patch a mix of 2 bugs? Please split that in 2 patches in 2 different bugs.
Whiteboard: [land-in-fx-team]
Updated•12 years ago
|
Blocks: DevToolsPaperCuts
Assignee | ||
Comment 7•12 years ago
|
||
carry forward r+ removed the other bug's patch from this one.
Attachment #703391 -
Attachment is obsolete: true
Attachment #705387 -
Flags: review+
Assignee | ||
Comment 8•12 years ago
|
||
my editor has some serious indentation issues -_- fixed an unintentional indentation.
Attachment #705387 -
Attachment is obsolete: true
Attachment #705388 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2bff5a9d9783
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2bff5a9d9783
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Updated•11 years ago
|
No longer blocks: DevToolsPaperCuts
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•