Closed
Bug 796086
Opened 12 years ago
Closed 12 years ago
protect against Obj-C exceptions in widget/cocoa/nsLookAndFeel
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: Irving, Assigned: Irving)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #417558 +++
For implementing the strategy we decided on in bug 163260 we are filing a bug for each top-level directory that needs work.
Since bug 415778 was committed it appears that new Objective-C calls have been added that lack Obj-C exception handling; this is showing in Thunderbird 15.0.1 topcrashers, bug 790229 and possibly bug 790232 (the stack is probably invalid in the latter).
|
Assignee | |
Comment 3•12 years ago
|
||
Added ObjC exception macros around two recently added methods.
Attachment #667086 -
Flags: review?(smichaud)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 667086 [details] [diff] [review]
Add Obj-C try/catch macros around recently added methods
This looks OK -- at least it shouldn't do any harm.
But I wonder if it'll really help with bug 790229. Time will tell, guess.
Attachment #667086 -
Flags: review?(smichaud) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: NEW → ASSIGNED
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•