Closed
Bug 796164
Opened 12 years ago
Closed 12 years ago
Change NECKO_UNKNOWN_APP_ID to UINT32_MAX
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)
References
Details
Bug 791906 changed it to
#define NECKO_UNKNOWN_APP_ID std::numeric_limits<uint32_t>::max()
But that is causing things like
MOZ_ASSERT(appId != NECKO_UNKNOWN_APP_ID);
to barf on windows with
nsNetUtil.h(1362) : warning C4003: not enough actual parameters for macro 'max'
nsNetUtil.h(1364) : warning C4003: not enough actual parameters for macro 'max'
nsNetUtil.h(1364) : error C2589: '(' : illegal token on right side of '::'
nsNetUtil.h(1364) : error C2059: syntax error : '::'
nsNetUtil.h(1364) : error C2143: syntax error : missing ';' before '{'
|
Assignee | |
Updated•12 years ago
|
OS: Linux → Windows 7
|
||
Comment 1•12 years ago
|
||
Bug 794023 did that.
|
||
Comment 2•12 years ago
|
||
Either (std::numeric_limits<uint32_t>::max)() or #define NOMINMAX will work.
|
|
Assignee | |
Comment 3•12 years ago
|
||
:emk,
I landed UINT32_MAX before I saw your comment (got +r from ehsan on IRC). If you feel some other fix is better, please open a bug for it.
https://hg.mozilla.org/integration/mozilla-inbound/rev/064bf6c9fe16
This was blocking bug 786299 from landing (it still has other issues).
Blocks: 786299
|
||
Comment 4•12 years ago
|
||
Assignee: nobody → jduell.mcbugs
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•