Closed Bug 796182 Opened 12 years ago Closed 12 years ago

fix invalidation on Mac with OMTC

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
15 Branch
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: nrc, Assigned: nrc)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
(deleted), patch
cjones
: review+
Details | Diff | Splinter Review
DLBI seems to have broken OMTC on Mac
POssibly related: bug 972119 and bug 792120
Blocks: 780692
OS: Windows 7 → Mac OS X
Hardware: x86_64 → All
Blocks: 756601
I don't think it was DLBI after all, more likely bug 792663
Depends on: 792663
No longer depends on: dlbi
Summary: fix OMTC on Mac → fix invalidation on Mac with OMTC
Attached patch patch (deleted) — — Splinter Review
When we stopped calling sync... from the buffer update (i.e., the reply from the Shadow layer) (in the 'single buffered' case), we delayed validating the layer until the next sync call, which overwrites that transaction's valid area, this caused errors with invalidation. Fix this by moving validation in this case to the buffer update method.
Attachment #667399 - Flags: review?(jones.chris.g)
Blocks: 792663
No longer depends on: 792663
Keywords: regression
Attachment #667399 - Flags: review?(jones.chris.g) → review+
https://hg.mozilla.org/mozilla-central/rev/136440ce1cd0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: