Closed Bug 796658 Opened 12 years ago Closed 12 years ago

Audio settings should be separated

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

defect

Tracking

(blocking-basecamp:+)

VERIFIED FIXED
B2G C1 (to 19nov)
blocking-basecamp +

People

(Reporter: ghtobz, Assigned: alive)

References

Details

(Keywords: feature, Whiteboard: [label:settings][LOE:S])

Attachments

(1 file)

[GitHub issue by vingtetun on 2012-09-17T11:03:14Z, https://github.com/mozilla-b2g/gaia/issues/4797] Created based on the discussion in https://github.com/mozilla-b2g/gaia/issues/2562#issuecomment-8610682 Master volume and Voice volume are currently synced in the platform and needs to be splitted https://bugzilla.mozilla.org/show_bug.cgi?id=791642 Once this is done the UI can reflect 2 channels for volume and turn off sounds coming from a music player when there is a phone call for example.
[GitHub comment by marcofreda527 on 2012-09-26T03:56:56Z] First step: a. Gaia initializes each stream volume to middle value and keep volume adjustment on master volume. b. Gecko lands the patch for stream volume API on AudioManager and modify setting.js to reflect Gaia modification. Setting name: audio.volume.XXX (ex:audio.volume.voice_call) Stream Types with max levels (defined in gecko and refer to Android): voice_call : 5 system : 7 ring : 7 music : 15 alarm : 7 notification: 7 BT_SCO : 15 enforced : 7 DTMF : 15 TTS : 15 FM : 15
Depends on: 791642
blocking-basecamp: --- → +
Priority: -- → P1
Macro, is the max levels still accurate or we are going to normalize them all to 10 or 1?
Flags: needinfo?(mchen)
The maximum value on each steams can be adjustable. So they can be set to all maximum value of 10 (maybe for V1). On the other way, I think the original design from Android is to optimize the user experience. For example, there is no necessary to have much levels on case of voice_call but need more levels on music for enjoying music on a more suitable volume level.
Flags: needinfo?(mchen)
(In reply to Marco Chen [:mchen] from comment #3) > The maximum value on each steams can be adjustable. So they can be set to > all maximum value of 10 (maybe for V1). > > On the other way, I think the original design from Android is to optimize > the user experience. > For example, there is no necessary to have much levels on case of voice_call > but need more levels on music for enjoying music on a more suitable volume > level. Hmm, this reflects to its UI, too. But limit the maximum to the same value(1or10) doesn't conflict with the design that how many segments it divided into, does it?
http://code.google.com/p/ics-custom-services/source/browse/audioflinger/AudioFlinger.cpp?r=1899c9df4b68885df4f351fa9feee603a08ee8ec#2165 Refer to the code of audio flinger above, the more maximum index also means more big volume on output. Could we put maximum and current index of each stream types in settings? So gaia can know how to divided level bar on UI and configure by your self.
Priority: P1 → --
Priority: -- → P1
We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule). If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.
Target Milestone: --- → B2G C1 (to 19nov)
Keywords: feature
Component: Gaia → Gaia::Settings
To clarify, the remaining gaia work here is: * According to the finalized stream/channel type 1. determine which channel/stream type could be set in settings app. 2. write all audio volume default value to build/settings.py 3. add stream type to all audio tag in apps if needed.(The one who use default channel could be ignored). 4. Hardware volume button behavior(Tracked in bug 810780)
Attached file PR6423 (deleted) —
This patch: 1. Add mozAudioChannelType to all audio/video if necessary. 2. Add more volume slider to settings app 3. Modify sound manager behavior 4. Set default value to all channels if necessary.
Attachment #681930 - Flags: review?(timdream+bugs)
Comment on attachment 681930 [details] PR6423 r=me, with two review comment addressed. Thanks for the quick fix!!
Attachment #681930 - Flags: review?(timdream+bugs) → review+
Depends on: 812391
https://github.com/mozilla-b2g/gaia/commit/bd284fb5fdc540865a720e3a1394a37c487a49f9 Merged. Although 812391 is not landed, but this patch can live well without that.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Device: Unagi Build: 20130104070203 Verified that patch exists.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: