Closed
Bug 797237
Opened 12 years ago
Closed 12 years ago
Port Telemetry tests to mochitests
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
DUPLICATE
of bug 808161
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file)
(deleted),
patch
|
froydnj
:
feedback+
|
Details | Diff | Splinter Review |
Telemetry tests are currently xpcshell. This makes Telemetry incompatible with workers and OS.File. We should port them to mochitests before we consider porting Telemetry I/O to OS.File.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dteller
Assignee | ||
Comment 1•12 years ago
|
||
Porting test_nsITelemetry.js. Some of the conversion was done manually, some with regexps. Taras, what do you think of the result?
A few notes:
- there were a number of errors and inconsistencies in the original code, I have tried to fix them along the way;
- atm, this test leaks a string buffer – not quite sure where.
Attachment #669122 -
Flags: feedback?(taras.mozilla)
Comment 2•12 years ago
|
||
Comment on attachment 669122 [details] [diff] [review]
Porting test_nsITelemetry.js
Nathan owns this now.
Attachment #669122 -
Flags: feedback?(taras.mozilla) → feedback?(nfroyd)
Comment 3•12 years ago
|
||
Comment on attachment 669122 [details] [diff] [review]
Porting test_nsITelemetry.js
Review of attachment 669122 [details] [diff] [review]:
-----------------------------------------------------------------
Looks sane enough to me.
Attachment #669122 -
Flags: feedback?(nfroyd) → feedback+
Comment 4•12 years ago
|
||
There is ongoing work to make Components go away...I can't find the bug right now, my searches are not working in bugzilla or zimbra. I'm sure folks would appreciate if you looked up what was going on there and tried to write the tests according to the New World Order. :)
Assignee | ||
Comment 5•12 years ago
|
||
TUrns out that we may not need this at all: bug 808161.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•