Closed Bug 797300 Opened 12 years ago Closed 12 years ago

Skip pay provider selector in navigator.mozPay() when only one JWT

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(1 file)

v1
(deleted), patch
ferjm
: review+
Details | Diff | Splinter Review
Since we are not solving this on the platform, this is the appropriate Gaia bug for Bug 793811.
Attached patch v1 (deleted) — — Splinter Review
Assignee: nobody → ferjmoreno
Attachment #667413 - Flags: review?(francisco.jordano)
Blocks: 767818
Comment on attachment 667413 [details] [diff] [review] v1 Review of attachment 667413 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me :) just the lint question. Thanks! ::: apps/system/js/payment.js @@ +68,1 @@ > requests[i].productPrice[0].amount + ' ' + is this code passing the linter?
(In reply to francisco.jordano from comment #2) > Comment on attachment 667413 [details] [diff] [review] > v1 > > Review of attachment 667413 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good to me :) just the lint question. > > Thanks! > > ::: apps/system/js/payment.js > @@ +68,1 @@ > > requests[i].productPrice[0].amount + ' ' + > > is this code passing the linter? I don't know. I can't trigger the linter :\
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #3) > (In reply to francisco.jordano from comment #2) > > Comment on attachment 667413 [details] [diff] [review] > > v1 > > > > Review of attachment 667413 [details] [diff] [review]: > > ----------------------------------------------------------------- > > > > Looks good to me :) just the lint question. > > > > Thanks! > > > > ::: apps/system/js/payment.js > > @@ +68,1 @@ > > > requests[i].productPrice[0].amount + ' ' + > > > > is this code passing the linter? > > I don't know. I can't trigger the linter :\ I think you can `make lint` in your local working gaia directory?
I did that, thanks! `make lint | grep payment` shows no error, so I'll go with the merge.
Comment on attachment 667413 [details] [diff] [review] v1 Thanks :). r+ based on the comment above.
Attachment #667413 - Flags: review?(francisco.jordano) → review+
https://github.com/mozilla-b2g/gaia/pull/5652
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Keywords: verifyme
QA Contact: jsmith
Verified on 10/11 Otoro build.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: