Windows-only code was not fixed before landing bug 778980, because this warning is not supported by MSVC. They are errors when compiling with GCC/mingw.

Also fixes: HangMonitor.cpp:311:9: warning: enumeration value ‘kGeneralActivity’ not handled in switch [-Wswitch]

Also fixes: NPEventWindows.h:101:81: warning: comparison is always true due to limited range of data type [-Wtype-limits] nsPluginsDirWin.cpp:283:10: warning: unused variable ‘bCheck’ [-Wunused-variable] nsPluginNativeWindowWin.cpp:697:29: warning: unused variable ‘win’ [-Wunused-variable] and --disable-accessibility builds that failed in nsNPAPIPlugin::RunPluginOOP

Also fixes: nsPrintingPromptService.cpp:99:10: warning: unused variable ‘hWnd’ [-Wunused-variable] nsPrintingPromptService.cpp:45:18: warning: ‘gInstance’ defined but not used [-Wunused-variable]

Also fixes: GLContextProviderWGL.cpp:506:14: warning: variable ‘isCurrent’ set but not used [-Wunused-but-set-variable]

Also fixes a few set but unused variables and: gfxGDIFontList.cpp:284:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Also fixes: SyncChannel.h:166:13: warning: ‘mozilla::ipc::SyncChannel::mTimeoutMs’ will be initialized after [-Wreorder] SyncChannel.h:100:21: warning: ‘mozilla::ipc::SyncChannel::SyncStackFrame* mozilla::ipc::SyncChannel::mTopFrame’ [-Wreorder] SyncChannel.cpp:27:1: warning: when initialized here [-Wreorder] SyncChannel.cpp:91:13: warning: unused variable ‘msgSeqno’ [-Wunused-variable] WindowsMessageLoop.cpp:466:14: warning: unused variable ‘currentWndProc’ [-Wunused-variable] WindowsMessageLoop.cpp:95:5: warning: ‘{anonymous}::gEventLoopDepth’ defined but not used [-Wunused-variable]

Also fixes -Wreorder warning

Also fixes: nsMIMEInfoWin.cpp:823:3: warning: multi-line comment [-Wcomment] and a few similar ones.

(In reply to Jacek Caban from comment #6) > Created attachment 667429 [details] [diff] [review] > SyncChannel.cpp:91:13: warning: unused variable ‘msgSeqno’ > [-Wunused-variable] Fixed in bug 797111.

Comment on attachment 667433 [details] [diff] [review] uriloader part I'm not sure why I was tagged to review this, but it looks fine to me. Damn Windows and backslashes in paths...

(In reply to Jacek Caban from comment #0) > Windows-only code was not fixed before landing bug 778980, because this > warning is not supported by MSVC. They are errors when compiling with > GCC/mingw. Thanks for fixing these, Jacek. If Windows GCC/mingw builds were part of the tinderbox/try server, I would have caught them. <:)

Comment on attachment 667429 [details] [diff] [review] ipc/ part bent is a better reviewer for the win32 code here.

Comment on attachment 667435 [details] [diff] [review] widget/windows part I think this is more Jimm's area than mine.

Comment on attachment 667435 [details] [diff] [review] widget/windows part Builds ok w/msvc. Thanks for the patches!

Comment on attachment 667418 [details] [diff] [review] dom/plugins part I'm not plugin module peer, redirecting request to Josh

Comment on attachment 667421 [details] [diff] [review] gfx/gl part Review of attachment 667421 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!

Thanks for all reviews. https://hg.mozilla.org/integration/mozilla-inbound/rev/5d2aec62e155 https://hg.mozilla.org/integration/mozilla-inbound/rev/64ac66fde0af https://hg.mozilla.org/integration/mozilla-inbound/rev/37046745e742 https://hg.mozilla.org/integration/mozilla-inbound/rev/8913d486d3f4 https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a5f910c446 https://hg.mozilla.org/integration/mozilla-inbound/rev/65b1536aee04 https://hg.mozilla.org/integration/mozilla-inbound/rev/aaefd3bb4dba https://hg.mozilla.org/integration/mozilla-inbound/rev/bd36f348362b https://hg.mozilla.org/integration/mozilla-inbound/rev/1415aa5411b1

(In reply to Chris Peterson (:cpeterson) from comment #12) > Thanks for fixing these, Jacek. If Windows GCC/mingw builds were part of the > tinderbox/try server, I would have caught them. <:) mingw builds are Tier 3, so this is an acceptable state of affairs.

https://hg.mozilla.org/mozilla-central/rev/5d2aec62e155 https://hg.mozilla.org/mozilla-central/rev/64ac66fde0af https://hg.mozilla.org/mozilla-central/rev/37046745e742 https://hg.mozilla.org/mozilla-central/rev/8913d486d3f4 https://hg.mozilla.org/mozilla-central/rev/d4a5f910c446 https://hg.mozilla.org/mozilla-central/rev/65b1536aee04 https://hg.mozilla.org/mozilla-central/rev/aaefd3bb4dba https://hg.mozilla.org/mozilla-central/rev/bd36f348362b https://hg.mozilla.org/mozilla-central/rev/1415aa5411b1