Closed
Bug 797435
Opened 12 years ago
Closed 12 years ago
IonMonkey: Add rooting of IC stub IonCodes to OOL exit frames for callouts from those stubs.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: djvj, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This is needed so that IC stubs don't get collected when they're on the stack. The OOLJSNativeGetterExitFrame and OOLPropertyOpExitFrame types need an extra field containing the IonCode they're executing under, so we can mark them during scanning.
|
Reporter | |
Comment 1•12 years ago
|
||
Some minor additional cleanup on top of just adding the stubCode field: OOLNativeGetterExitFrames were marking the |this| value (target of the getprop) by just offsetting off of the |vp| value. Added an explicit method to retrieve the |this| pointer for marking, and changed marking code to do that.
Attachment #667567 -
Flags: review?(dvander)
|
||
Updated•12 years ago
|
Attachment #667567 -
Flags: review?(dvander) → review+
|
|
Reporter | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•