Jesse Ruderman Assignee
	Description • 12 years ago

Loading the testcase triggers:

JavaScript error: chrome://browser/content/browser.js, line 3019: NS_ERROR_FAILURE: Failure

This corresponds to line 40 of browser-plugins.js:

40     let navMimeType = navigator.mimeTypes[tagMimetype];

This line does the wrong thing if tagMimeType is a number, or any property that exists on navigator.mimeTypes ("__proto__", "watch", "length", etc).

	Jesse Ruderman Assignee
	Comment 1 • 12 years ago

(untested)

	Dana Keeler (she/her) (use needinfo) (:keeler for reviews)
	Comment 3 • 12 years ago

Comment on attachment 667798 [details] [diff] [review]
suggested fix

Review of attachment 667798 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I think Jared will have to give the actual r+.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 4 • 12 years ago

Comment on attachment 667798 [details] [diff] [review]
suggested fix

Review of attachment 667798 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. As discussed in person, please push it to try server.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 5 • 12 years ago

David, can you write a browser-chrome test for this to make sure that an invalid mimetype doesn't generate a chrome error? I believe devtools has a test that checks for error counts in a webpage.

	Jesse Ruderman Assignee
	Comment 6 • 12 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/ca5f40f6edc6

	Jesse Ruderman Assignee
	Comment 7 • 12 years ago

Filed bug 798237 so we don't forget to add a test.

	Ed Morley [:emorley]
	Comment 8 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/ca5f40f6edc6