Closed
Bug 797945
Opened 12 years ago
Closed 7 years ago
Nested <embed> tags cause "overlayText is null" in gPluginHandler::handleEvent::PluginClickToPlay
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jruderman, Unassigned)
References
Details
(Keywords: testcase)
Attachments
(1 file)
(deleted),
application/xhtml+xml
|
Details |
1. Set user_pref("plugins.click_to_play", true); 2. Load the testcase JavaScript error: chrome://browser/content/browser.js, line 3142: overlayText is null http://hg.mozilla.org/mozilla-central/annotate/4cb8f88213f5/browser/base/content/browser-plugins.js#l169 > let overlayText = doc.getAnonymousElementByAttribute(plugin, "class", "msg msgClickToPlay"); > overlayText.textContent = messageString;
Updated•12 years ago
|
Assignee: nobody → dkeeler
OS: Mac OS X → All
Hardware: x86_64 → All
Version: unspecified → 18 Branch
This looks to me like another case where the binding doesn't get attached when it should. Either that or we're loading the plugin again when we're not supposed to.
Comment 2•12 years ago
|
||
Which element is the binding not being attached to? The inner <embed> never gets a frame, of course.... Would that matter here?
The inner <embed> is not getting the binding, which makes sense if it never gets a frame. However, we're still firing the PluginClickToPlay event for it, which I think might not be right.
Comment 4•12 years ago
|
||
Yeah, that seems a bit odd, since it will never actually be clickable, ever.
I'm pretty sure this was fixed by bug 800018. Should we add this testcase to the test suite so we (in theory) don't regress?
Assignee: dkeeler → nobody
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•