Bug 754472 changed activatePluginsMessage.label from "Activate plugins" to "Activate All Plugins" (http://hg.mozilla.org/mozilla-central/diff/644aac25b7ab/browser/locales/en-US/chrome/browser/browser.properties#l1.13 ) without changing the entity name. Apparently this shouldn't have happened.

Is this good? Or should I change all of the activatePluginsMessage.whatever entities to be consistent?

Comment on attachment 668088 [details] [diff] [review] patch Review of attachment 668088 [details] [diff] [review]: ----------------------------------------------------------------- Yes, thanks.

Comment on attachment 668088 [details] [diff] [review] patch I'm assuming that was a yes to the first question, not the second :) Anyway, asking for review from Jared.

Comment on attachment 668088 [details] [diff] [review] patch Review of attachment 668088 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/locales/en-US/chrome/browser/browser.properties @@ +119,5 @@ > carbonFailurePluginsMessage.message=This page asks to use a plugin that can only run in 32-bit mode > carbonFailurePluginsMessage.restartButton.label=Restart in 32-bit mode > carbonFailurePluginsMessage.restartButton.accesskey=R > activatePluginsMessage.message=Would you like to activate the plugins on this page? > +activateAllPluginsMessage.label=Activate All Plugins As discussed on IRC with Stephen, we should just revert this to "Activate Plugins" and keep the entity name unchanged. 12:09 PM <jaws> shorlander: did you help with the text for CTP plugins? 12:14 PM <shorlander> jaws: not extensively 12:14 PM <shorlander> what specifically 12:14 PM <jaws> the "Activate All Plugins", I think it can just be "Activate Plugins". the addition of "All" complicates our l10n without adding much benefit. 12:16 PM <fryn> jaws: good point. i second that. 12:17 PM <shorlander> I am ok with that For Aurora: Since the entity name didn't change, we can leave the string as-is and not uplift this change. For Trunk: we shouldn't ask our localizers to make this text change since the meaning of it hasn't changed.

Ok - this one reverts "Activate All Plugins" to "Activate plugins". Axel - will this work for l10n?

Comment on attachment 668153 [details] [diff] [review] patch Review of attachment 668153 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, I guess we can message this out.

Comment on attachment 668153 [details] [diff] [review] patch >+activatePluginsMessage.label=Activate plugins plugins => Plugins

(In reply to Dão Gottwald [:dao] from comment #7) > Comment on attachment 668153 [details] [diff] [review] > patch > > >+activatePluginsMessage.label=Activate plugins > > plugins => Plugins Just to be very clear, you're saying we should capitalize "Plugins", even though it was uncapitalized before bug 754472 landed?

Comment on attachment 668088 [details] [diff] [review] patch I thought more about this and I changed my mind. The popup shows like so: > > Adobe Flash ................ [Activate] > Java ....................... [Activate] > > ................ [Activate All Plugins] > So the difference between Activate Plugins and Activate All Plugins does help here IMO. I think the original text was better than my proposed changed.