Due to BluetoothHfp/ScoManager inheriting from both nsISupports and RefCounted<>, we get double releases when they die.

Get() never worked in this configuration, and we have no need for an SCOCommandThread.

Comment on attachment 668203 [details] [diff] [review] Patch 2 (v1) - General SCO class cleanup Review of attachment 668203 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bluetooth/BluetoothScoManager.cpp @@ -100,3 @@ > BluetoothScoManager::Cleanup() > { > // Shut down the command thread if it still exists. Also remove the comment here.

Comment on attachment 668201 [details] [diff] [review] Patch 1 (v1) - Make observers internal friend classes of managers Review of attachment 668201 [details] [diff] [review]: ----------------------------------------------------------------- Looks good :) ::: dom/bluetooth/BluetoothScoManager.cpp @@ +66,5 @@ > + const PRUnichar* aData) > +{ > + if (!strcmp(aTopic, NS_XPCOM_SHUTDOWN_OBSERVER_ID)) { > + return gBluetoothScoManager->HandleShutdown(); > + } We probably need to check gBluetootScoManager before calling its function. MOZ_ASSERT(gBluetoothScoManager);

https://hg.mozilla.org/integration/mozilla-inbound/rev/a170f959971e https://hg.mozilla.org/integration/mozilla-inbound/rev/b7731c744c7f

https://hg.mozilla.org/mozilla-central/rev/a170f959971e https://hg.mozilla.org/mozilla-central/rev/b7731c744c7f