Closed
Bug 798198
Opened 12 years ago
Closed 11 years ago
social sidebar should be hidden when toolbar is not visible.
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: markh, Unassigned)
References
Details
(Whiteboard: [1.5])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
eg, on about:addons, the toolbar is hidden, so there are no ambient toolbar notifications shown for the social feature, but the social sidebar remains visible.
Reporter | ||
Comment 1•12 years ago
|
||
For reference, this will probably involve adding a tab switch event handler and calling hideChromeForLocation (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4169)
Also, this will probably require the ability to have different sidebar states per browser window, so blocked by bug 798201
Comment 2•12 years ago
|
||
I don't feel strongly that we have to fix this. If a patch is easy, let's get it but if not, this can definitely wait.
Comment 3•12 years ago
|
||
This patch is close, but I think the event listener isn't entirely correct since it doesn't handle switching tabs, only changing the location of the current tab.
Updated•12 years ago
|
Whiteboard: [1.5]
Comment 4•11 years ago
|
||
bug 935640 made the social sidebar work like and look more like other existing sidebars. All other sidebars do not become hidden in the situation described in this bug. Should the social sidebar be different in that respect alone?
Flags: needinfo?(jboriss)
Comment 5•11 years ago
|
||
Actually, Australis no longer hides the toolbar in about:addons/etc. as well, so this is WONTFIX.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jboriss)
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•