Closed
Bug 798437
Opened 12 years ago
Closed 12 years ago
aboutSocialError.xhtml doesn't include Social.jsm with the right url
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(firefox17 fixed)
RESOLVED
FIXED
Firefox 18
Tracking | Status | |
---|---|---|
firefox17 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #668496 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•12 years ago
|
Version: 14 Branch → 18 Branch
Updated•12 years ago
|
Attachment #668496 -
Flags: review?(gavin.sharp) → review?(felipc)
Updated•12 years ago
|
Attachment #668496 -
Flags: review?(felipc) → review+
Comment 2•12 years ago
|
||
I'll roll up this change together with the patches from bug 766616 when uplifiting it to aurora
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4bb09009a54
Comment 3•12 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9678df7672 because something in the push was hitting "browser_frameworker.js | sub-test testEarlyClose failed: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.nukeSandbox]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/FrameWorker.jsm :: terminate :: line 239" data: no]" and "browser_frameworker.js | check that websockets worked - Got FAILED calling WebSocket constructor: TypeError: WebSocket is not a constructor, expected ok" and I didn't know which (though I presume bug 790201), and didn't know interconnectedness among them.
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Comment 6•12 years ago
|
||
fixed in aurora with cset https://hg.mozilla.org/releases/mozilla-aurora/rev/b69ca3697450
status-firefox17:
--- → fixed
Flagging [qa-] as I don't think this needs QA verification. Please correct me if I am wrong.
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•