Closed
Bug 798516
Opened 12 years ago
Closed 12 years ago
Remove support for gPrivateBrowsingUI.privateWindow
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
PrivateBrowsingUtils.isWindowPrivate is a better API.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #668661 -
Flags: review?(josh)
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Comment on attachment 668661 [details] [diff] [review]
Patch (v1)
Review of attachment 668661 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js
@@ +29,4 @@
> executeSoon(function() {
> let ui = aSubject.gPrivateBrowsingUI;
> is(ui.privateBrowsingEnabled, expected, "The privateBrowsingEnabled property on the new window is set correctly");
> + is(PrivateBrowsingUtils.isWindowPrivate(window), expected, "The private bit on the new window is set correctly");
This should be aSubject
Attachment #668661 -
Flags: review?(josh) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in
before you can comment on or make changes to this bug.
Description
•