Closed Bug 798794 Opened 12 years ago Closed 12 years ago

Followup on bug 795654 - Artwork appears to be coming out pixelated or patched in stub installer

Categories

(Firefox :: Installer, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 19
Tracking Status
firefox18 --- verified

People

(Reporter: jsmith, Assigned: robert.strong.bugs)

References

Details

(Keywords: polish, Whiteboard: [stub+])

Attachments

(6 files)

Upon trying to install firefox nightly with the stub installer, I noticed that a lot of artwork is coming out pixelated and patch-like. Examples: - Firefox Nightly on the stub installer came out pixelated * http://screencast.com/t/TSXhviGd - Arrow icons are pixelated with white pieces showing * http://screencast.com/t/VdJkVwi5 We should clean this up to make the artwork look polished.
Blocks: 795654
Attached image screenshot (deleted) —
Some additional detail as to your graphic settings would be helpful. I am seeing this.
Attached image intro screenshot (deleted) —
Here is what I see for the intro screen.
Attached image downloading screenshot (deleted) —
And the downloading screen
Attachment #669263 - Attachment description: screenshot 1 → intro screenshot
Dave, can you give the details asked for in comment #2?
(In reply to Robert Strong [:rstrong] (do not email) from comment #5) > Dave, can you give the details asked for in comment #2? This looks to be a DPI scaling issue. I run with DPI at 125% (claims to be the default but maybe that's because of my screen size). With the option "Use Windows XP style DPI scaling" which is apparently the default in Vista and above in certain screen sizes, the jagged edges are there. Turning that off gives smoother edges though some of the text is a little blurry. My main screen size is 1920x1200, my secondary screen runs at 1600x900
Awesome and thanks for the info
Keywords: polish
Increasing the size of the images and scaling down solves this for me so I've requested artwork to fix this.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Whiteboard: [stub=]
Whiteboard: [stub=] → [stub+]
Attached file stub.exe test (deleted) —
If anyone experiencing this bug could try this out and report back their findings I'd appreciate it. Thanks
(In reply to Robert Strong [:rstrong] (do not email) from comment #9) > Created attachment 669338 [details] > stub.exe test > > If anyone experiencing this bug could try this out and report back their > findings I'd appreciate it. Thanks Tried this out on my machine that was having this bug. This worked for me in that I did not get pixelated or patch-like "Firefox Nightly" wording, the images looked polished and not patch-like as I've seen on other machines. In short - looks good!
Cool and thanks! I noticed that some of the images had variances in the color at the larger sizes so I am going to wait on shorlander to provide new images which won't likely happen until sometime Wednesday since he is on vacation.
(In reply to Robert Strong [:rstrong] (do not email) from comment #9) > Created attachment 669338 [details] > stub.exe test > > If anyone experiencing this bug could try this out and report back their > findings I'd appreciate it. Thanks Tried this myself on my Win7 machine with 3 monitors.. it fixes the pixelation!
I think this is already known, but just in case if this isn't - this bug also affects the Aurora build of the stub installer. So it isn't just Nightly-specific.
Attached patch new artwork rev1 (deleted) — Splinter Review
It is time for some binary patch reviewing ;)
Attachment #670269 - Flags: review?(netzen)
The images are likely larger than needed and we will revisit this when we have more breathing room. The way the code is written the images were already resized to fit the control and this change is only needed because additional padding of the image was required to add the fade from the main image color to the background color to prevent the jagged edges.
Attachment #670270 - Flags: review?(netzen)
Attachment #670269 - Flags: review?(netzen) → review+
Attachment #670270 - Flags: review?(netzen) → review+
Pushed to mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/30555cdf10e5 https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a03b8cbcc6 The release artwork still needs to be checked with different DPI settings and I'll do that today when I have a chance.
Keywords: verifyme
QA Contact: jsmith
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Attachment #670269 - Flags: approval-mozilla-aurora?
Attachment #670270 - Flags: approval-mozilla-aurora?
Attachment #670269 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #670270 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified on Nightly 10/12.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: