Closed
Bug 798794
Opened 12 years ago
Closed 12 years ago
Followup on bug 795654 - Artwork appears to be coming out pixelated or patched in stub installer
Categories
(Firefox :: Installer, defect)
Tracking
()
VERIFIED
FIXED
Firefox 19
Tracking | Status | |
---|---|---|
firefox18 | --- | verified |
People
(Reporter: jsmith, Assigned: robert.strong.bugs)
References
Details
(Keywords: polish, Whiteboard: [stub+])
Attachments
(6 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
application/octet-stream
|
Details | |
(deleted),
patch
|
bbondy
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bbondy
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Upon trying to install firefox nightly with the stub installer, I noticed that a lot of artwork is coming out pixelated and patch-like. Examples:
- Firefox Nightly on the stub installer came out pixelated
* http://screencast.com/t/TSXhviGd
- Arrow icons are pixelated with white pieces showing
* http://screencast.com/t/VdJkVwi5
We should clean this up to make the artwork look polished.
Reporter | ||
Updated•12 years ago
|
Blocks: StubInstaller
Assignee | ||
Comment 2•12 years ago
|
||
Some additional detail as to your graphic settings would be helpful. I am seeing this.
Comment 3•12 years ago
|
||
Here is what I see for the intro screen.
Comment 4•12 years ago
|
||
And the downloading screen
Updated•12 years ago
|
Attachment #669263 -
Attachment description: screenshot 1 → intro screenshot
Assignee | ||
Comment 5•12 years ago
|
||
Dave, can you give the details asked for in comment #2?
Comment 6•12 years ago
|
||
(In reply to Robert Strong [:rstrong] (do not email) from comment #5)
> Dave, can you give the details asked for in comment #2?
This looks to be a DPI scaling issue. I run with DPI at 125% (claims to be the default but maybe that's because of my screen size). With the option "Use Windows XP style DPI scaling" which is apparently the default in Vista and above in certain screen sizes, the jagged edges are there. Turning that off gives smoother edges though some of the text is a little blurry.
My main screen size is 1920x1200, my secondary screen runs at 1600x900
Assignee | ||
Comment 7•12 years ago
|
||
Awesome and thanks for the info
Assignee | ||
Comment 8•12 years ago
|
||
Increasing the size of the images and scaling down solves this for me so I've requested artwork to fix this.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Reporter | ||
Updated•12 years ago
|
Whiteboard: [stub=]
Reporter | ||
Updated•12 years ago
|
Whiteboard: [stub=] → [stub+]
Assignee | ||
Comment 9•12 years ago
|
||
If anyone experiencing this bug could try this out and report back their findings I'd appreciate it. Thanks
Reporter | ||
Comment 10•12 years ago
|
||
(In reply to Robert Strong [:rstrong] (do not email) from comment #9)
> Created attachment 669338 [details]
> stub.exe test
>
> If anyone experiencing this bug could try this out and report back their
> findings I'd appreciate it. Thanks
Tried this out on my machine that was having this bug. This worked for me in that I did not get pixelated or patch-like "Firefox Nightly" wording, the images looked polished and not patch-like as I've seen on other machines.
In short - looks good!
Assignee | ||
Comment 11•12 years ago
|
||
Cool and thanks!
I noticed that some of the images had variances in the color at the larger sizes so I am going to wait on shorlander to provide new images which won't likely happen until sometime Wednesday since he is on vacation.
Comment 12•12 years ago
|
||
(In reply to Robert Strong [:rstrong] (do not email) from comment #9)
> Created attachment 669338 [details]
> stub.exe test
>
> If anyone experiencing this bug could try this out and report back their
> findings I'd appreciate it. Thanks
Tried this myself on my Win7 machine with 3 monitors.. it fixes the pixelation!
Reporter | ||
Comment 13•12 years ago
|
||
I think this is already known, but just in case if this isn't - this bug also affects the Aurora build of the stub installer. So it isn't just Nightly-specific.
Assignee | ||
Comment 14•12 years ago
|
||
It is time for some binary patch reviewing ;)
Attachment #670269 -
Flags: review?(netzen)
Assignee | ||
Comment 15•12 years ago
|
||
The images are likely larger than needed and we will revisit this when we have more breathing room. The way the code is written the images were already resized to fit the control and this change is only needed because additional padding of the image was required to add the fade from the main image color to the background color to prevent the jagged edges.
Attachment #670270 -
Flags: review?(netzen)
Updated•12 years ago
|
Attachment #670269 -
Flags: review?(netzen) → review+
Updated•12 years ago
|
Attachment #670270 -
Flags: review?(netzen) → review+
Assignee | ||
Comment 16•12 years ago
|
||
Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/30555cdf10e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a03b8cbcc6
The release artwork still needs to be checked with different DPI settings and I'll do that today when I have a chance.
Comment 17•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/30555cdf10e5
https://hg.mozilla.org/mozilla-central/rev/a0a03b8cbcc6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Assignee | ||
Updated•12 years ago
|
Attachment #670269 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•12 years ago
|
Attachment #670270 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #670269 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•12 years ago
|
Attachment #670270 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 18•12 years ago
|
||
Verified on Nightly 10/12.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Assignee | ||
Comment 19•12 years ago
|
||
Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e74bb1ef08f
https://hg.mozilla.org/releases/mozilla-aurora/rev/7e4667059308
status-firefox18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•