Richard Newman [:rnewman] Reporter
	Description • 12 years ago

As observed in Bug 798835:

Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface] Stack trace: resource://services-sync/engines/passwords.js:84

Relevant code:

84:    return Services.logins.QueryInterface(Ci.nsIInterfaceRequestor)
                      .getInterface(Ci.mozIStorageConnection);

	Asa Dotzler [:asa]
	Comment 1 • 12 years ago

Can someone explain why we need this for v1? What is the impact of having or not having it?

	Richard Newman [:rnewman] Reporter
	Comment 2 • 12 years ago

Unless I'm mistaken, passwords won't sync, instead logging an exception.

	Asa Dotzler [:asa]
	Comment 3 • 12 years ago

Well, that's kind of important :)  Blocking the sync tracker for now. If we're going to sync in v1, we should certainly try to sync the passwords.

	Justin Dolske [:Dolske]
	Comment 4 • 11 years ago

This should be a straightforward fix -- jettison the password mananger fork that came over with fennec/xul, and just use the existing toolkit version. IIRC, the fork was intended to be a temporary measure to get the password manager working in E10S fennec when that was in omgship-mode.

	Justin Dolske [:Dolske]
	Comment 5 • 11 years ago

I'm just going to morph, as my last comment suggests. That will both fix the mozIStorageConnection issue, and allow Metro Firefox to take advantage of significant upcoming password manager changes (856470 and 853549).

	Matt Brubeck (:mbrubeck) Assignee
	Comment 6 • 11 years ago

We might need some slight changes to our nsILoginManagerPrompter to make sure it implements the correct interface and works with toolkit's nsILoginManager implementation.  Or maybe we can use toolkit's prompter code, and just override its strings and use CSS to change the labels and buttons.

	Matt Brubeck (:mbrubeck) Assignee
	Comment 7 • 11 years ago

I decided to go with the path of least resistance and keep our LoginManagerPrompter for now.  We use somewhat different UX for our notifications, and just overriding the toolkit strings would be a pain if we ever want to make changes that require updating the property names.

The new code here is copied from toolkit, to bring our LoginManagerPrompter more in line with theirs.

	Matt Brubeck (:mbrubeck) Assignee
	Comment 8 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9437f13fa3d2

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/9437f13fa3d2