Closed
Bug 799197
Opened 12 years ago
Closed 12 years ago
throw an error from talos if we do not collect all the counters in xperf that we intend to collect
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
oh errors, we need more of ye.
We found a changeset that didn't collect any xperf data, but ran through the test just fine. We know what counters we want to collect, so we need to enforce this collection and throw an error if we did not collect our predefined set.
Maybe we shrink our set so we can be green.
Comment 1•12 years ago
|
||
We currently don't throw any errors if we don't collect counter data that we expect to collect:
http://hg.mozilla.org/build/talos/file/e351f3aa6ecc/talos/output.py#l207
Do we want to change this across the board?
Assignee | ||
Comment 2•12 years ago
|
||
we probably should, otherwise what is the point of collecting it?
Assignee | ||
Comment 3•12 years ago
|
||
nice and simple, green on try.
Comment 4•12 years ago
|
||
Comment on attachment 670507 [details] [diff] [review]
remove unused counters and throw an error if we do not report a value for one we are trying to collect (1.0)
looks good to me :)
Attachment #670507 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•