Netscape 6.5/2001050914 build 1. Modify Name in New Directory| General 2. OK to New Directory dialog 3. The Name listed in LDAP Directory Servers dialog is not updated 4. Close out LDAP Directory Servers dialog 5. Click on Edit Directories button 6. The updated Name then shows up

ccing Bhuvan for review ccing Seth for sr

now ccing

r=mohanb;

+ dump("gNewServer is " + gNewServer + "\n"); Srilatha, please don't add new dumps to the tree.

ok, r=mohanb;

+ if(gRefresh) + { + var directoriesTree = document.getElementById("directoriesTree"); + var selectedNode = directoriesTree.selectedItems[0]; + var row = selectedNode.firstChild; + var cell = row.firstChild; + cell.setAttribute('label', gNewServer); + cell.setAttribute('string', gNewServerString); + window.opener.gRefresh = true; + } it seems like that should be: + window.opener.gRefresh = false; + } or am I confused?

+ if(gRefresh) + { + var directoriesTree = document.getElementById("directoriesTree"); + var selectedNode = directoriesTree.selectedItems[0]; + var row = selectedNode.firstChild; + var cell = row.firstChild; + cell.setAttribute('label', gNewServer); + cell.setAttribute('string', gNewServerString); //You are right. here I need to have gRefresh = false; + window.opener.gRefresh = true; but the window.opener is for either Addressing Panel in global preferences or ServerSettings panel in Mail/News Account Settings. I need to have window.opener.gRefresh = true so that the dropdown list box in the above mentioned panels will be refreshed. Will post a patch with the change right away.

I *think* I understand what you're doing here, but it's pretty confusing. you should comment this code so it's clear why you set gRefresh to false, but window.opener.gRefresh to true. having them be the same name (gRefresh) adds to the confusion. I recommend renaming these so it's clear what they are going to refresh. another, cleaner approach would be to have a method that does the "refresh", instead of setting globals like this.

Sorry, for the confusion. I have added comments and also updated one gRefresh to gUpdate.

sr=sspitzer, assuming mohanb is ok with it.

r=mohanb;

a=dbaron for trunk checkin (on behalf of drivers)

Fix checked in

Verified with 2001061304 winds trunk build