Closed
Bug 799272
Opened 12 years ago
Closed 12 years ago
[jsdbg2] Debugger.Object should provide a way to get the global, and to unwrap
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: jimb, Assigned: jimb)
References
Details
Attachments
(2 files)
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
There should be a way to find the global in whose scope an object was allocated; and to unwrap Debugger.Object instances referring to wrappers, when security permits. Together these operations will let debuggers make better sense of their referent's wrapper and compartment structure.
Draft spec:
https://github.com/jimblandy/DebuggerDocs/compare/wrapper-inspection
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=83d6ae92cfbc
Will request reviews when this looks good.
Assignee | ||
Updated•12 years ago
|
Attachment #669631 -
Flags: review?(jorendorff)
Assignee | ||
Updated•12 years ago
|
Attachment #669632 -
Flags: review?(jorendorff)
Comment 4•12 years ago
|
||
Comment on attachment 669631 [details] [diff] [review]
Implement Debugger.Object.prototype.global.
Stealing at jimb's request.
Makes sense. Good tests.
Attachment #669631 -
Flags: review?(jorendorff) → review+
Comment 5•12 years ago
|
||
Comment on attachment 669632 [details] [diff] [review]
Implement Debugger.Object.prototype.unwrap.
Ditto.
On irc I asked about, generally, whether it is an error to have a Debugger.Object to an object in a non-debuggee global. The answer was "we tolerate that". I guess if we ever decided not to do that, makeDebuggeeValue would be pinch-point to change.
Attachment #669632 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/708db1ae8d66
https://hg.mozilla.org/integration/mozilla-inbound/rev/147285c88028
Flags: in-testsuite+
Target Milestone: --- → Firefox 19
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/708db1ae8d66
https://hg.mozilla.org/mozilla-central/rev/147285c88028
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•